Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120316
MIME-Version: 1.0
References: <e58dde83-654d-b0ad-de77-d0450a56ef75@bastelstu.be>
In-Reply-To: <e58dde83-654d-b0ad-de77-d0450a56ef75@bastelstu.be>
Date: Tue, 16 May 2023 17:17:46 +0100
Message-ID: <CA+kxMuT6mL7fhyaA+cMfHjHcS+5uA52ELUKz0c_8dRv-8+ZV1g@mail.gmail.com>
To: =?UTF-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] RFC [Discussion]: Marking overridden methods (#[\Override])
From: Danack@basereality.com (Dan Ackroyd)

On Thu, 11 May 2023 at 17:37, Tim D=C3=BCsterhus <tim@bastelstu.be> wrote:
>
> Hi
>
> I'm now opening discussion for the RFC "Marking overridden methods
> (#[\Override])":
>
> I'm now opening discussion for the RFC "Marking overridden methods (#[\Ov=
erride])":

This RFC is probably a good idea, even if the number of people who
will benefit from the behaviour in the engine might be quite low. My
guess is the number of people who will bother to write those
attributes, and who also won't bother to setup CI, is quite small.

But, this RFC another step forward from where we are, to having 'too
many' attributes/annotations, so I have a question.

How do we stop prevent ourselves from copying the problems that Java
has made for itself?

Or putting it another way, is it possible for us to set any guidelines
on what annotations are 'good' or 'bad' ?

I hope I am at least consistent with my concerns about annotations.

Danack wrote in https://externals.io/message/114116#114196
>
> I think I disagree with this very strongly, and plan* to vote against
> any RFC that embeds another language in annotations.**

> https://blog.softwaremill.com/the-case-against-annotations-4b2fb170ed67

cheers
Dan
Ack