Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120310
MIME-Version: 1.0
References: <CAFPFaMJ1opg7=SZ2ovFiAqjO_z1avpcNPFWTOoOqjhptoxSvcg@mail.gmail.com>
 <CAFPFaMJZniU6GyLO4FTZSNT776VYeCsuY8+ekzv-REfJog+1fQ@mail.gmail.com> <CAPTD5yEue+G9h+XuYRKomgLr21Fs9MGNMe0CnJ9Gpib-EhgDMw@mail.gmail.com>
In-Reply-To: <CAPTD5yEue+G9h+XuYRKomgLr21Fs9MGNMe0CnJ9Gpib-EhgDMw@mail.gmail.com>
Date: Tue, 16 May 2023 13:29:41 +0100
Message-ID: <CAFPFaMLL9d=rstw+D6ZW0-8wLkJN3U6bDXt0iNsDahQbMnCptw@mail.gmail.com>
To: Jorg Sowa <jorg.sowa@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000006f21f705fbceba7d"
Subject: Re: [PHP-DEV] [RFC] Define proper semantics for range() function
From: george.banyard@gmail.com ("G. P. B.")

--0000000000006f21f705fbceba7d
Content-Type: text/plain; charset="UTF-8"

On Mon, 15 May 2023 at 23:53, Jorg Sowa <jorg.sowa@gmail.com> wrote:

> Hello!
>
> I have one concern about the part:
>
> > Emit an E_WARNING when $start or $end is cast to an integer because the
> other boundary input is a number or numeric string. (e.g. range
> <http://www.php.net/range>('5', 'z'); or range <http://www.php.net/range>(
> 5, 'z');)
>
> Doesn't it limit the functionality of the function for the numbers as
> characters? Currently when we call range('/','z') we get full range of
> characters. https://onlinephp.io/c/9cb12
>
> But when we change argument $start to next character which is zero ('0')
> then we get array with only one element. https://onlinephp.io/c/a0cda
>
> Casting numerical string in this function may be confusing.
>
> Sorry for making fuss just before voting, but didn't see this topic before
> and wanted to share my insights with you thinking it may be relevant.
>

No worries, this is the point of giving a heads-up.
Someone else brought this to my attention again as well.
And the concern makes sense, I've updated the implementation and RFC to
adjust the behaviour with string digits:
https://wiki.php.net/rfc/proper-range-semantics

Please let me know if this addresses the issue and is also clear.

Best regards,

George P. Banyard

--0000000000006f21f705fbceba7d--