Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:12030 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 88895 invoked by uid 1010); 9 Aug 2004 07:01:11 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 85926 invoked from network); 9 Aug 2004 07:00:42 -0000 Received: from unknown (HELO jdi.jdimedia.nl) (212.204.192.51) by pb1.pair.com with SMTP; 9 Aug 2004 07:00:42 -0000 Received: from localhost (localhost [127.0.0.1]) by jdi.jdimedia.nl (8.12.11/8.12.11) with ESMTP id i7970f8l005542 for ; Mon, 9 Aug 2004 09:00:41 +0200 Received: from localhost (localhost [127.0.0.1]) by jdi.jdimedia.nl (8.12.11/8.12.11) with ESMTP id i7970bdr005521; Mon, 9 Aug 2004 09:00:37 +0200 Date: Mon, 9 Aug 2004 09:00:36 +0200 (CEST) X-X-Sender: derick@localhost To: Joe Orton cc: internals@lists.php.net In-Reply-To: <20040807160217.GA15321@redhat.com> Message-ID: References: <20040723211815.GB15309@redhat.com> <20040807160217.GA15321@redhat.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Scanned: by amavisd-new at jdimedia.nl Subject: Re: [PHP-DEV] [PATCH] fix symbol namespace pollution from bundled libgd From: derick@php.net (Derick Rethans) On Sat, 7 Aug 2004, Joe Orton wrote: > That would mean adding exactly the reverse set of #defines to allow the > the GD extension to be built against an external copy of libgd (which of > course won't use the phpgd_* symbols). > > Given that a complete set of #defines is needed anyway, doing it without > modifying libgd makes more sense since it's then easier to track the > upstream libgd sources. Right ;-) Can you please update your patch with the new symbols then? I'll commit it then later (or just ask for a CVS account!) Derick