Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120287
MIME-Version: 1.0
References: <20230509000325.76dad6a7@platypus> <CABAhh3H1-sFmGVP1Z4h7Lr0hG339fcrad2SBy91QvLeBEgGK-Q@mail.gmail.com>
In-Reply-To: <CABAhh3H1-sFmGVP1Z4h7Lr0hG339fcrad2SBy91QvLeBEgGK-Q@mail.gmail.com>
Date: Mon, 15 May 2023 17:02:16 +0100
Message-ID: <CAFPFaMJJFbB2n81GmR7hcgCQE8yUq4L1rEaw4deqkbWgMMPwCQ@mail.gmail.com>
To: someniatko <someniatko@gmail.com>
Cc: BohwaZ <php@bohwaz.net>, PHP internals list <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000d073b005fbbd9497"
Subject: Re: [PHP-DEV] [VOTE] Use exceptions by default in SQLite3 extension
From: george.banyard@gmail.com ("G. P. B.")

--000000000000d073b005fbbd9497
Content-Type: text/plain; charset="UTF-8"

On Mon, 15 May 2023 at 15:41, someniatko <someniatko@gmail.com> wrote:

> The `PDOException` class is actually extending the `RuntimeException`,
> not just `Exception`.
>

Yes, and this is, IMHO, a mistake.
Outside SPL, there are only 4 extensions which extend from RuntimeException:
 - PDO
 - MySQLi
 - SNMP
 - Phar

See:
https://heap.space/search?project=php-src&full=&defs=&refs=spl_ce_RuntimeException&path=&hist=&type=

The vast majority of extensions that define their own custom exceptions
extend Exceptions.
The reason being that depending on a separate extension (here SPL) instead
of core API is less than ideal.

Moreover, SPL exceptions are meant for userland.
And I personally find it extremely strange that if I attempt to catch a
RuntimeException I might as well catch a PDO failure.

Best regards,

George P. Banyard

--000000000000d073b005fbbd9497--