Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120280
MIME-Version: 1.0
References: <641b1ca0-d33f-4f38-ae64-81b4abce24da@app.fastmail.com> <CAG4FTXzt6qnpawSgPftnuXhNz9b1RAPtrOvVwvgY723W6WeLDA@mail.gmail.com>
In-Reply-To: <CAG4FTXzt6qnpawSgPftnuXhNz9b1RAPtrOvVwvgY723W6WeLDA@mail.gmail.com>
Date: Mon, 15 May 2023 10:32:48 +0200
Message-ID: <CANS-=pfcmsHkBCpis+zO8zSy4=rc+HH=7o4zT5iBGEAdtYdj_w@mail.gmail.com>
To: Hendra Gunawan <the.liquid.metal@gmail.com>
Cc: Larry Garfield <larry@garfieldtech.com>, php internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000044da6205fbb74e22"
Subject: Re: [PHP-DEV] [RFC] Property hooks, nee accessors
From: kjarli@gmail.com (Lynn)

--00000000000044da6205fbb74e22
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, May 15, 2023 at 1:41=E2=80=AFAM Hendra Gunawan <the.liquid.metal@gm=
ail.com>
wrote:

> 2. The shorthand notations supported (the shortest one) creates
> impaired syntax, and not pretty to look at for constructor property
> promotion.
>

It's starting to get crowded in object constructors. The following example
is so much more readable and maintainable imo. Would it be possible to
still add the quick assignment as a language feature? I'm personally not
happy having property definitions in both the class body _and_ the
constructor signature.

```php
class User {
    private string $first;
    private string $last;
    public string $fullName {
        get =3D> $this->first . ' ' . $this->last;
        set =3D> [$this->first, $this->last] =3D explode(' ', $value, 2);
    }

    public function __construct($this->fullName) {}
}

// vs

class User {
    private string $first;
    private string $last;

    public function __construct(
        public string $fullName {
            get =3D> $this->first . ' ' . $this->last;
            set =3D> [$this->first, $this->last] =3D explode(' ', $value, 2=
);
        }
    ) {}
}

// or

class User {
    private string $first;
    private string $last;
    public string $fullName {
        get =3D> $this->first . ' ' . $this->last;
        set =3D> [$this->first, $this->last] =3D explode(' ', $value, 2);
    }

    public function __construct(string $fullName)
    {
        $this->fullName =3D $fullName;
    }
}

```

--00000000000044da6205fbb74e22--