Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120276
MIME-Version: 1.0
References: <641b1ca0-d33f-4f38-ae64-81b4abce24da@app.fastmail.com>
In-Reply-To: <641b1ca0-d33f-4f38-ae64-81b4abce24da@app.fastmail.com>
Date: Mon, 15 May 2023 06:41:12 +0700
Message-ID: <CAG4FTXzt6qnpawSgPftnuXhNz9b1RAPtrOvVwvgY723W6WeLDA@mail.gmail.com>
To: Larry Garfield <larry@garfieldtech.com>
Cc: php internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [RFC] Property hooks, nee accessors
From: the.liquid.metal@gmail.com (Hendra Gunawan)

On Tue, May 9, 2023 at 4:38=E2=80=AFAM Larry Garfield <larry@garfieldtech.c=
om> wrote:
>
> Ilija Tovilo and I would like to offer another RFC for your consideration=
.  It's been a while in coming, and we've evolved the design quite a bit ju=
st in the last week so if you saw an earlier draft of it in the past few mo=
nths, I would encourage you to read it over again to make sure we're all on=
 the same page.  I'm actually pretty happy with where it ended up, even if =
it's not the original design.  This approach eliminates several hard-to-imp=
lement edge cases while still providing a lot of functionality in one packa=
ge.
>
> https://wiki.php.net/rfc/property-hooks
>
> --
>   Larry Garfield
>   larry@garfieldtech.com
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: https://www.php.net/unsub.php
>

Hi Larry.

```
public string $fullName =3D> $this->first . " " . $this->last;
```
1. Suppose that I forgot to declare ```$this->first```. Based on the
"deprecate dynamic properties" proposal, will I get an error/warning?

2. The shorthand notations supported (the shortest one) creates
impaired syntax, and not pretty to look at for constructor property
promotion.

```
public function __construct(
  public string $prop1 =3D> strtoupper($this->_prop1),
  public string $prop2 {set =3D> $field =3D strtolower($value);},
){}
```

My suggestion is: use get/set keyword immediately after property
name/default value rather than "=3D>" or "{" without losing multiline
statements.
```
public function __construct(
  public string $prop1 get =3D> strtoupper($this->_prop1),
  public string $prop2 set =3D> $field =3D strtolower($value),
  public string $prop3 get {
    $temp =3D strtoupper($this->_prop1);
    return substr($temp, 0, 10) . '...';
  }
  public string $prop4 set {
    $temp =3D strtolower($value);
    $field =3D substr($temp, 0, 10);
  }
){}
```
This syntax is aligned with a single statement if/for/foreach.