Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120218
Message-ID: <40e1f208-4bda-bd8e-da28-2341948b343d@gmail.com>
Date: Tue, 9 May 2023 13:52:12 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
To: internals@lists.php.net
References: <641b1ca0-d33f-4f38-ae64-81b4abce24da@app.fastmail.com>
Content-Language: en-US
In-Reply-To: <641b1ca0-d33f-4f38-ae64-81b4abce24da@app.fastmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [RFC] Property hooks, nee accessors
From: dik.takken@gmail.com (Dik Takken)



On 08-05-2023 23:38, Larry Garfield wrote:
> Ilija Tovilo and I would like to offer another RFC for your consideration.  It's been a while in coming, and we've evolved the design quite a bit just in the last week so if you saw an earlier draft of it in the past few months, I would encourage you to read it over again to make sure we're all on the same page.  I'm actually pretty happy with where it ended up, even if it's not the original design.  This approach eliminates several hard-to-implement edge cases while still providing a lot of functionality in one package.
> 
> https://wiki.php.net/rfc/property-hooks
> 

Thanks for all the work that has gone into this. It looks great. The 
ability to add properties to interfaces is also really nice.

One thing that concerns me is the following: "the use of [] on any 
property (with or without a key) will result in a runtime error being 
thrown". While the intent of the RFC is to allow adding hooks without 
causing BC breaks, this detail does introduce a BC break. And the break 
may get introduced without realizing it.

I'm not sure which solution would be best here: Just accept the 
limitations for arrays (same as for list properties in Python) or forbid 
the use of hooks for array properties? I'm leaning towards accepting the 
limitations, like Python does. Then it is up to the API designer to 
decide if a property hook is the right tool for the job or not.

Regards,
Dik