Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120215
MIME-Version: 1.0
References: <641b1ca0-d33f-4f38-ae64-81b4abce24da@app.fastmail.com>
In-Reply-To: <641b1ca0-d33f-4f38-ae64-81b4abce24da@app.fastmail.com>
Date: Tue, 9 May 2023 09:39:44 +0200
Message-ID: <CABdc3WoyMKbGx-O-5ZnAveCJNE5WEX=J67OzbNHG=4Mt0eaX6w@mail.gmail.com>
To: Larry Garfield <larry@garfieldtech.com>
Cc: php internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000008a9ab405fb3ddc0b"
Subject: Re: [PHP-DEV] [RFC] Property hooks, nee accessors
From: michal.brzuchalski@gmail.com (=?UTF-8?Q?Micha=C5=82_Marcin_Brzuchalski?=)

--0000000000008a9ab405fb3ddc0b
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Larry,

pon., 8 maj 2023 o 23:38 Larry Garfield <larry@garfieldtech.com> napisa=C5=
=82(a):

> Ilija Tovilo and I would like to offer another RFC for your
> consideration.  It's been a while in coming, and we've evolved the design
> quite a bit just in the last week so if you saw an earlier draft of it in
> the past few months, I would encourage you to read it over again to make
> sure we're all on the same page.  I'm actually pretty happy with where it
> ended up, even if it's not the original design.  This approach eliminates
> several hard-to-implement edge cases while still providing a lot of
> functionality in one package.
>
> https://wiki.php.net/rfc/property-hooks


> Using $this->propertyName directly is supported, but not recommended.
Why is that? IMHO in the scope of accessor this is much clearer to me than
using the $field.

> The following example does make use of $field, however, and thus a
backing value will be created, and write operations will simply write to
the property as normal.
This looks like new magic to me, whether we allow setting and baking the
value explicitly or not. I consider this behavior confusing.

Overall I vote yes.
Cheers,
Micha=C5=82 Marcin Brzuchalski

--0000000000008a9ab405fb3ddc0b--