Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120204
Feedback-ID: i8414410d:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-386-g2404815117-fm-20230425.001-g24048151
Mime-Version: 1.0
Message-ID: <97c44cf8-14bb-4735-ab2e-3ec04636e8e3@app.fastmail.com>
In-Reply-To: 
 <CAF-mU4wGmqTYdJO=vT_ZoJ1GLumsq8OdpN4H3JhQffWfvoqPLw@mail.gmail.com>
References: <67b1e9b0-b7c6-71d4-cad2-2286edab759b@daniil.it>
 <5536a702-4a15-86d2-a178-8d0ef8797e50@php.net>
 <CAAKU0umjg9735XZtLvz2HfCLA_7EOUAq9P9MxyTyhkTUAzK=ZQ@mail.gmail.com>
 <CAF-mU4wGmqTYdJO=vT_ZoJ1GLumsq8OdpN4H3JhQffWfvoqPLw@mail.gmail.com>
Date: Sat, 06 May 2023 10:20:32 -0500
To: "php internals" <internals@lists.php.net>
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Final anonymous classes
From: larry@garfieldtech.com ("Larry Garfield")

On Sat, May 6, 2023, at 2:16 AM, Rokas =C5=A0leinius wrote:
> On Fri, 5 May 2023 at 23:58, Levi Morrison via internals
> <internals@lists.php.net> wrote:
>>
>> I am not sure about making them final by default. I think it's a more
>> consistent language design to allow `new final class()` as you
>> originally proposed. Although I don't know why anyone would want to
>> extend anonymous classes, we can see that people do, in fact, do it. I
>> don't see why we couldn't allow `new class() extends $someClass` in
>> the future to specifically allow them to do this. I mean, I'm not
>> going to lobby for it, I'm just pointing out that is more aligned and
>> consistent with other parts of the language, than to simply make it
>> final by default.
>>
>> Cheers.
>>
>> --
>> PHP Internals - PHP Runtime Development Mailing List
>> To unsubscribe, visit: https://www.php.net/unsub.php
>>
>
> My work currently is integrating with various shipping provider APIs
> such as DHL. I have to deal with the enormous API request (and
> response) definitions. I am just creating a DTO class for each level
> of JSON key, which results in a HUGE amount of classes.
>
> I have a hunch this problem can be solved better with anonymous
> classes, but their support is not great yet - PHPStorm has a breaking
> bug with their autocompletion and I am too dumb to figure out a better
> solution in any case.

I think you're on the right track with named classes, honestly.  With cu=
rrent PHP versions that's syntactically a lot nicer than it used to be.

> However, I totally agree with Levi in that the way forward is better
> towards `new class() extends $someClass` and not "all anonymous
> classes final by default". It may open patterns and opportunities we
> have yet to think about.

My understanding of the engine implementation is that extending from a c=
lass dynamically would be really really hard.  (Anon classes are not def=
ined at runtime, they get defined at compile time, just with an auto-gen=
erated name.)  That said, I have to agree here as well that I'm not a fa=
n of forcing anon classes to be final, but if someone could figure out d=
ynamic-extension anon classes, I would be a happy camper.

--Larry Garfield