Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120199
Return-Path: <tim@bastelstu.be>
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 28840 invoked from network); 5 May 2023 19:59:47 -0000
Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5)
  by pb1.pair.com with SMTP; 5 May 2023 19:59:47 -0000
Received: from php-smtp4.php.net (localhost [127.0.0.1])
	by php-smtp4.php.net (Postfix) with ESMTP id A222A180503
	for <internals@lists.php.net>; Fri,  5 May 2023 12:59:46 -0700 (PDT)
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net
X-Spam-Level: 
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,
	T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.2
X-Spam-ASN: AS24940 176.9.0.0/16
X-Spam-Virus: No
X-Envelope-From: <tim@bastelstu.be>
Received: from chrono.xqk7.com (chrono.xqk7.com [176.9.45.72])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by php-smtp4.php.net (Postfix) with ESMTPS
	for <internals@lists.php.net>; Fri,  5 May 2023 12:59:45 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bastelstu.be;
	s=mail20171119; t=1683316784;
	bh=Lu82z1xLDG0eWHt29R+H+K0ZyTpnuHmLUJUzy1G6+yM=;
	h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:
	 In-Reply-To:Content-Type:from:to:cc:subject:message-id;
	b=FPe7vAM9Nba45ov79kyX1e6mGyl6SAdiHIzHUpMhrwKpOaIdGu2hPjDlOPHkktndc
	 o9SEFVwc5uVP/tgXO0S5buCuodWYhkCn14uBAijp8nY9vapCRfmlUQOZ+jP6ICKQYt
	 NwyBVZpnb7/kcRRSX0K7irYeoxub9xdWQ8nyzBO8qo4xQxwMztKQ0M+QZohv2J7YuV
	 Xxy9UaCS4cV1FGfuLlZhNLpex8qt3joAQkEwFW/QLCG1BIZboOnkJKyU7wKNP8kVqF
	 EmSK8yFAckkLxmcNzgWW8h6/NzJZPwGGOBA3klLel7hZroKbMY3joHAhEZa0s6YBxs
	 q+t1fi41ae+Fg==
Message-ID: <f071bb40-03b8-96bb-7acb-c23244a825a7@bastelstu.be>
Date: Fri, 5 May 2023 21:59:40 +0200
MIME-Version: 1.0
To: Derick Rethans <derick@php.net>, =?UTF-8?B?TcOhdMOpIEtvY3Npcw==?=
 <kocsismate90@gmail.com>
Cc: PHP Internals List <internals@lists.php.net>
References: <CAH5C8xXtCVHaxwzmAW_eBxp_D6p7kww9svND=3AEeC9X6--YXg@mail.gmail.com>
 <eaaa805e-86b2-ce8c-5a24-c301260d16ac@php.net>
Content-Language: en-US
In-Reply-To: <eaaa805e-86b2-ce8c-5a24-c301260d16ac@php.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] [RFC] [Discussion] Deprecate functions with overloaded
 signatures
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=c3=bcsterhus?=)

Hi

On 5/5/23 18:12, Derick Rethans wrote:
> createFromIso8601(string $specification, int $options = 0)
> -> createFromISO8601String
> 
> I am open to bike shedding about this :-)

Okay, I'd like a different color of my bikeshed:

Please no consecutive uppercase letters in the function name. I find 
createFromIso8601 (or createFromIso8601String if find the 'String' 
suffix useful) much more readable than createFromISO8601String. 
Uppercase acronyms are especially bad if followed by another ucfirst 
word, because the word boundary is not immediately visible there. Not 
the case here (it's digits), but still bad.

Best regards
Tim Düsterhus