Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120176
MIME-Version: 1.0
References: <CAH5C8xXtCVHaxwzmAW_eBxp_D6p7kww9svND=3AEeC9X6--YXg@mail.gmail.com>
 <CAGBsUrdFgHg7BPXCYiU0yfUtKWAUL3xGPoKmaOprgqs3NKsuEw@mail.gmail.com> <CAH5C8xULMjDtbiRGOZGhrbuF+EkprsznCasPzj7u6ykgRHDU3Q@mail.gmail.com>
In-Reply-To: <CAH5C8xULMjDtbiRGOZGhrbuF+EkprsznCasPzj7u6ykgRHDU3Q@mail.gmail.com>
Date: Tue, 2 May 2023 12:37:42 +0100
Message-ID: <CA+kxMuTRQLCaQhaORdktLMjbzf3XFz2d-q3sw0hD0K2VYCZosw@mail.gmail.com>
To: =?UTF-8?B?TcOhdMOpIEtvY3Npcw==?= <kocsismate90@gmail.com>
Cc: Kamil Tekiela <tekiela246@gmail.com>, PHP Internals List <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [RFC] [Discussion] Deprecate functions with overloaded signatures
From: Danack@basereality.com (Dan Ackroyd)

Kamil Tekiela wrote:
> > I think one year of deprecation is not enough... It doesn't make
> > sense to me to add a replacement but not deprecate the old variant.

M=C3=A1t=C3=A9 Kocsis <kocsismate90@gmail.com> wrote:
> Yes, this upgrade path also makes sense to me, and I'm happy to go with
> it if others don't disagree!


For the functions that are having new separate methods added, not
deprecating them immediately makes upgrading easier. When upgrading
from one version of PHP to the next, it is best if you can run the
same code on both versions, without any deprecation notices going off.

Would leaving the current versions in place and working actually cause
any maintenance issues?

If not, then we could just move really slowly on deprecating them. We
could deprecate them at some point in the 9.x release cycle and remove
them in 10.0.

The RFC says:

> Impact analysis: 1 out of the 2000 most popular PHP packages rely on call=
ing session_set_save_handler() with 6 or more arguments.

I doubt analysing github is going to give a useful measure of the
impact of this RFC. Functions like session_set_save_handler are going
to be used in custom code written for a company than in shared
libraries.

cheers
Dan
Ack