Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120161
MIME-Version: 1.0
References: <CACtG6sBr1C5eu=RSocUfsSk8O34uh+UROvfxcezVoz=2er6umw@mail.gmail.com>
 <e840a521-2353-e1d2-e1eb-50f28c705adf@bastelstu.be> <CACtG6sABqTCQY7n+zjpXu0V9AD=0zhhnFrjMHxMmHoYiiZT8Dw@mail.gmail.com>
In-Reply-To: <CACtG6sABqTCQY7n+zjpXu0V9AD=0zhhnFrjMHxMmHoYiiZT8Dw@mail.gmail.com>
Date: Sat, 29 Apr 2023 12:47:03 +0200
Message-ID: <CANS-=pd5Y3JTfMLRe_zdsO8=pU4fezrf66a-yFW1z7bWqsytXg@mail.gmail.com>
To: Garet Claborn <garet@suiteux.com>
Cc: =?UTF-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>, internals@lists.php.net
Content-Type: multipart/alternative; boundary="000000000000ee70d205fa7750df"
Subject: Re: [PHP-DEV] Request for RFC Karma - Enum value semantics proposal
From: kjarli@gmail.com (Lynn)

--000000000000ee70d205fa7750df
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Apr 28, 2023 at 11:48=E2=80=AFPM Garet Claborn <garet@suiteux.com> =
wrote:

> You are correct, thank you.
>
> The RFC draft has been posted to
> https://wiki.php.net/rfc/treat_enum_instances_as_values
>
> -Garet
>
>
I think this example should be "mixed" instead of "$mixed"? `public
function offsetGet($mixed $which){`

Maybe a bit of a side-track, what about an interface with a method that
lets an object specify what it would turn into if it were used as an array
key? In the case of enums that would mean they'd implement this interface
and just return the value. I hadn't seen this idea come by yet and I don't
know if it's a good idea, just something I was thinking of while trying to
group data objects based on a value. In theory this could also be done with
Stringable instead.

https://3v4l.org/Vi8kY#v8.2.5
```php
<?php

interface ArrayKeyable {
    public function toArrayKey(): string|int;
}

final class MyObject implements ArrayKeyable
{
    public function __construct(
        public readonly int $id,
        public readonly string $name,
    ) {}

    public function toArrayKey(): string {
        return $this->name;
    }
}

$objects =3D [];
$data    =3D [[1, 'Jane'], [2, 'John'], [3, 'Jake'], [4, 'Jane']];
foreach($data as [$id, $name]) {
    $object =3D new MyObject($id, $name);
    $objects[$object->toArrayKey()][] =3D $object;
    // would turn into $objects[$object][] =3D $object;
}

var_dump($objects);
```

--000000000000ee70d205fa7750df--