Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120132
To: internals@lists.php.net
References: <67b1e9b0-b7c6-71d4-cad2-2286edab759b@daniil.it>
Message-ID: <64485EB4.5090901@adviesenzo.nl>
Date: Wed, 26 Apr 2023 01:13:56 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.0
MIME-Version: 1.0
In-Reply-To: <67b1e9b0-b7c6-71d4-cad2-2286edab759b@daniil.it>
Content-Type: multipart/alternative;
 boundary="------------010903040008020800060502"
Subject: Re: [PHP-DEV] Final anonymous classes
From: php-internals_nospam@adviesenzo.nl (Juliette Reinders Folmer)

--------------010903040008020800060502
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit

On 24-4-2023 12:28, Daniil Gentili wrote:
> Hi all,
>
> I've submitted https://github.com/php/php-src/pull/11126 to add 
> support for final anonymous classes, though as noted by iluuu1994, it 
> would probably make more sense to just make all anonymous classes 
> final by default, what do you think?
>
> Daniil Gentili.
>

I always though anonymous class where `final` by nature. The fact that 
that hack to extend them works, seems iffy at best.

For what it's worth, I'd be in favour of making the default behaviour 
for anonymous classes `final` without the need to add a `final` keyword.

For those edge-cases which would be broken by that change, I wonder if 
support to opt-out could be added via an `#[AllowAliasing]` attribute ?

--------------010903040008020800060502--