Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120116
Feedback-ID: i8414410d:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-372-g43825cb665-fm-20230411.003-g43825cb6
Mime-Version: 1.0
Message-ID: <b6f875ff-6dc9-4eab-a9b5-1391b20f69a9@app.fastmail.com>
In-Reply-To: 
 <CAH5C8xV1GEMavuLJ033uR5QVk6SGiX4cQ_MbAfT64tOJh9OtaQ@mail.gmail.com>
References: 
 <CAH5C8xUn2wotLg0L7KZHoOGf3q-UqbL=47p2PLzK_mOBb=MJXQ@mail.gmail.com>
 <CAAwdEzCuLLd3uc-1Q+PaMW2PkJcg=KoP89vG+NXn5W3o+bvqFw@mail.gmail.com>
 <CAH5C8xV1GEMavuLJ033uR5QVk6SGiX4cQ_MbAfT64tOJh9OtaQ@mail.gmail.com>
Date: Sun, 23 Apr 2023 19:58:04 -0500
To: "php internals" <internals@lists.php.net>
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [RFC] [Discussion] Clone with
From: larry@garfieldtech.com ("Larry Garfield")

On Sun, Apr 23, 2023, at 6:01 PM, M=C3=A1t=C3=A9 Kocsis wrote:

> What about argument unpacking?
>> I don't know if we can combine this with ":" syntax or only with "=3D=
>".
>
>
> For now, argument unpacking (property unpacking?) is not possible. But=
 it
> is definitely something that could be added in the future.

Not currently written but could be, or there's some reason why that is p=
articularly hard?

> Tim wrote:
>
> I'd rather see only the fat-arrow being allowed. Unless I'm missing
>> something, braces with colon is not used anywhere else, whereas brace=
s +
>> '=3D>' is known from match() and '=3D>' more generally is already use=
d with
>> array literals [1]. Having two similar syntaxes for the same thing is
>> not great when both are commonly needed is not great. They need to be
>> documented and learned by developers.
>
>
> I can only repeat what Rowan answered, since I agree with it completel=
y:
>
> I think it makes sense to have an unquoted form here, because the comm=
on
>> case is that they are names which analysers can match statically to
>> particular properties, not strings which will be analysed at runtime.=
 There
>> are plenty of places in the language where dynamic names are allowed,=
 but
>> we don't just use strings for the static case
>
>
> However, I'm not completely sold on making "clone with" look like a
> function call (return clone $this with (a: 1);), but
> at least I like it more than using an array-like style (return clone=20
> $this
> with [a: 1];). My intention with
> using curly brackets (return clone $this with {a: 1};) is to highlight=20
> the
> fact that it is a map
> of key-value pairs, similarly how the JSON standard does so. Not to=20
> mention
> that "clone with" serves a very
> similar purpose to object initializers, and the different languages I=20
> know
> to have this feature use
> a similar syntax (Java: http://wiki.c2.com/?DoubleBraceInitialization,=20
> C#:
> https://learn.microsoft.com/en-us/dotnet/csharp/programming-guide/clas=
ses-and-structs/object-and-collection-initializers#object-initializers
> ).
>
> Regards,
> M=C3=A1t=C3=A9

True, but PHP 8.0 sort of added something close to object initializers w=
ith the combination of constructor promotion and named arguments.  It's =
not exactly the same thing, but it's the effective equivalent in PHP tod=
ay.  So if you want to model on object initializers, named args would be=
 the closest PHP equivalent.

--Larry Garfield