Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120111
Content-Type: multipart/alternative;
 boundary="------------qS1LWwdsGvXMLfNvt0VBm0rx"
Message-ID: <3e131a9b-9f5e-5eb0-33e4-a3a03327e157@gmail.com>
Date: Sun, 23 Apr 2023 18:53:38 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Content-Language: en-GB
To: internals@lists.php.net
References: <CACtG6sCFbMniVPwkib5FE6Oi=+-mEWT+tQuWuAZdyjQX3vR0Hw@mail.gmail.com>
In-Reply-To: <CACtG6sCFbMniVPwkib5FE6Oi=+-mEWT+tQuWuAZdyjQX3vR0Hw@mail.gmail.com>
Subject: Re: [PHP-DEV] Introduction - SuitespaceRnD
From: rowan.collins@gmail.com (Rowan Tommins)

--------------qS1LWwdsGvXMLfNvt0VBm0rx
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 19/04/2023 16:11, Garet Claborn wrote:
> Specifically I finally registered
> as I have written up an RFC in response to this issue thread
> <https://github.com/php/php-src/issues/9208>  on GitHub.


Welcome, and in case you haven't found it already, here's the guide to 
the RFC process: https://wiki.php.net/rfc/howto

I'll wait with interest to see the RFC, but would note two things:

- If the aim is to allow array keys to be enum cases themselves (or 
objects in general), you'll likely need at least a partial 
implementation before taking it to a vote, as the impact on the rest of 
the engine, in terms of performance and complexity, will be a major 
deciding factor. You can still draft the RFC beforehand to judge the 
interest, however.

- If the aim is to automatically cast the enum cases to ordinary strings 
or ints, expect some scepticism. I for one believe that it is an 
essential property of enums that Day::Monday == Month::January should be 
false, and it follows that array_key_exists(Day::Monday, [Month::January 
=> true]) should be false as well.


On 23/04/2023 17:01, Robert Landers wrote:
> Even if it
> has to be something 'ugly' to keep people from using that itself as a
> value (similar to how js symbol types work -- a one-way cast).


As far as I understand, Symbols in JS are entirely their own type, and 
the definition of objects directly allows property keys to be either a 
String or a Symbol; so it is equivalent to PHP allowing enum cases, but 
not other objects, to be array keys.

 > Properties are identified using key values. A property key value is 
either an ECMAScript String value or a Symbol value. All String and 
Symbol values, including the empty String, are valid as property keys.

https://tc39.es/ecma262/multipage/ecmascript-data-types-and-values.html#sec-object-type


Regards,

-- 
Rowan Tommins
[IMSoP]

--------------qS1LWwdsGvXMLfNvt0VBm0rx--