Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120082
Message-ID: <6e5dfd26-a333-de65-890f-5abc9dde91d1@alec.pl>
Date: Thu, 20 Apr 2023 19:17:33 +0200
MIME-Version: 1.0
To: internals@lists.php.net
References: <CAH5C8xUn2wotLg0L7KZHoOGf3q-UqbL=47p2PLzK_mOBb=MJXQ@mail.gmail.com>
 <CAAwdEzCuLLd3uc-1Q+PaMW2PkJcg=KoP89vG+NXn5W3o+bvqFw@mail.gmail.com>
 <687944e3-75ec-446b-bbd6-6d3d6856e864@app.fastmail.com>
 <1b842b25-c038-f647-67e1-b8c986b7d51d@bastelstu.be>
 <14DCA246-277A-44EC-B3A5-3809C5BCC7AA@gmail.com>
 <85835836-becb-d995-8966-9f996e0839b1@alec.pl>
 <55fe1b11-b3a3-4108-9cc4-900012d3116f@app.fastmail.com>
Content-Language: en-US
In-Reply-To: <55fe1b11-b3a3-4108-9cc4-900012d3116f@app.fastmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [RFC] [Discussion] Clone with
From: alec@alec.pl (Aleksander Machniak)

On 20.04.2023 16:15, Larry Garfield wrote:
>> or $point = clone($point, x: $x, y: $y, z: $z);
>>
>> Also, I didn't see it mentioned, but maybe for future scope, these new
>> arguments should be passed to __clone().
> 
> They should not.  See https://peakd.com/hive-168588/@crell/object-properties-part-2-examples .  I went through and experimented with different syntaxes, and passing arguments to __clone() was by far the worst option in practice. :-)

Sure, I didn't propose it to be a solution for "clone with", but rather, 
if we implement "clone with" (no matter in which way) this is "cloning 
an object with extra properties", so therefore one would ask to have 
access to these extra properties inside __clone(). I'm not sure how 
useful that could be, but maybe worth mentioning in future scope or 
somewhere in the RFC.

And I think this syntax should still be on the table, no need for a new 
keyword.

$point = clone($point, x: $x, y: $y, z: $z);

-- 
Aleksander Machniak
Kolab Groupware Developer        [https://kolab.org]
Roundcube Webmail Developer  [https://roundcube.net]
----------------------------------------------------
PGP: 19359DC1 # Blog: https://kolabian.wordpress.com