Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120078
Message-ID: <8a4ba8bc-8749-3e4d-7711-8e8974576764@gmail.com>
Date: Thu, 20 Apr 2023 09:21:12 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
To: php internals <internals@lists.php.net>
References: <CAH5C8xUn2wotLg0L7KZHoOGf3q-UqbL=47p2PLzK_mOBb=MJXQ@mail.gmail.com>
 <CAAwdEzCuLLd3uc-1Q+PaMW2PkJcg=KoP89vG+NXn5W3o+bvqFw@mail.gmail.com>
 <687944e3-75ec-446b-bbd6-6d3d6856e864@app.fastmail.com>
 <1b842b25-c038-f647-67e1-b8c986b7d51d@bastelstu.be>
 <14DCA246-277A-44EC-B3A5-3809C5BCC7AA@gmail.com>
 <CAPzBOBN_g3mhJZK8kQN9be-e5barTWMb06JWAvAb1dmZDood9Q@mail.gmail.com>
Content-Language: en-GB
In-Reply-To: <CAPzBOBN_g3mhJZK8kQN9be-e5barTWMb06JWAvAb1dmZDood9Q@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [RFC] [Discussion] Clone with
From: rowan.collins@gmail.com (Rowan Tommins)

On 20/04/2023 08:11, Robert Landers wrote:
> public function withStatus($code, $reasonPhrase = ''): Response
> {
>      return clone $this {
>          $this->statusCode = $code;
>           $this->reasonPhrase = "Old: $this->reasonPhrase, New: $reasonPhrase";
>      }
> };


Note that this is not the current proposed syntax. Since the keys are 
not dynamic, the current proposal is this:

public function withStatus($statusCode, $reasonPhrase = ''): Response {
   // perform validation here
   $reasonPhrase = "Old: $this->reasonPhrase, New: $reasonPhrase";
   return clone $this with {statusCode: $statusCode, reasonPhrase: $reasonPhrase};
}



> public function withStatus($statusCode, $reasonPhrase = ''): Response {
>    // perform validation here
>    $reasonPhrase = "Old: $this->reasonPhrase, New: $reasonPhrase";
>    return clone $this with compact('statusCode', 'reasonPhrase');
> }


The compact() function always feels like a relic of the same era as 
create_function() and call_user_func(), both of which now have dedicated 
syntax.

That's what Nikita was talking about in the RFC section I quoted 
earlier: that compact('foo', 'bar') could be replaced with a dedicated 
syntax like [:$foo, :$bar]

So if we insisted on arrays, that would be:

public function withStatus($statusCode, $reasonPhrase = ''): Response {
   // perform validation here
   $reasonPhrase = "Old: $this->reasonPhrase, New: $reasonPhrase";
   return clone $this with [:$statusCode, :$reasonPhrase];
}

But I still don't see why an array should be the default case here, 
rather than using ... to unpack one if you really need to, like we do 
with arguments.

public function withStatus($statusCode, $reasonPhrase = null): Response {
   $newProps = [:$statusCode];
   if ( $reasonPhrase !== null ) {
       $newProps['reasonPhrase'] = "Old: $this->reasonPhrase, New: $reasonPhrase";
   }
   return clone $this with (...$newProps);
}


Regards,

-- 
Rowan Tommins
[IMSoP]