Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:120051
MIME-Version: 1.0
References: <CAFPFaMLghRYP4ioCkfa7WKhTAz+1gWgcZ5mWYAunkb9f3g=fdA@mail.gmail.com>
 <A97A9A6E-DBE5-4BE6-98FE-C5A7381460E4@gmail.com> <3b7db03a-1cad-3762-b0ea-d33618be9644@gmail.com>
 <a492bd9e-7147-ce9a-83d8-2263a4ea0d00@seld.be> <CA+kxMuRhXMpRQq57+1=j7JRbNSFqnU4SNPFe2xGp1aiAwnkfQg@mail.gmail.com>
In-Reply-To: <CA+kxMuRhXMpRQq57+1=j7JRbNSFqnU4SNPFe2xGp1aiAwnkfQg@mail.gmail.com>
Date: Mon, 17 Apr 2023 10:21:51 +0200
Message-ID: <CAPzBOBO9b92bGzYiPWQ0Bvr9VXB9DbjHYv1VVm1BK1Fw-6o-fA@mail.gmail.com>
Cc: internals@lists.php.net
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] [RFC] New core autoloading mechanism with support for
 function autoloading
From: landers.robert@gmail.com (Robert Landers)

Hello,

This looks really interesting but it might be a good idea to add a
section for the definition of "pinning" and the scope of the pin. For
example, what is the output of this code, executed in this order (with
this new autoloading configured):

// Test.php

namespace Test {
  function password_verify(string $password, string $hash): bool {
return true; }
}

// another file

echo Test\password_verify('password', 'hash');
echo password_verify('password', 'hash');

// yet another file

echo password_verify('password', 'hash');

Does this get pinned in the global namespace and does this pin extend
to other files? If so, this could lead to very hard-to-reason-about
code.

Cheers,

Rob Landers
Utrecht, Netherlands