Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:119952
MIME-Version: 1.0
References: <CAEfSKhfvzNMNMxikpAT+hOXoYUUd5NHFM2txcLvotV70M6Fuxw@mail.gmail.com>
In-Reply-To: <CAEfSKhfvzNMNMxikpAT+hOXoYUUd5NHFM2txcLvotV70M6Fuxw@mail.gmail.com>
Date: Wed, 12 Apr 2023 12:53:42 +0100
Message-ID: <CALKiJKrnrzgdR1RdGS-G8b_Asw9XNES7qsvT-VObsZviPruk=Q@mail.gmail.com>
To: internals@lists.php.net
Content-Type: multipart/alternative; boundary="000000000000308bc805f9224352"
Subject: Re: [PHP-DEV] Possible RFC: $_SERVER['REQUEST_TIME_FLOAT']
From: rowan.collins@gmail.com (Rowan Tommins)

--000000000000308bc805f9224352
Content-Type: text/plain; charset="UTF-8"

On Wed, 12 Apr 2023 at 11:01, Herbert Groot Jebbink <
herbert@groot.jebbink.nl> wrote:

>
> I'm in the process of using hrtime(true) instead of microtime(true), for
> this it would be great if REQUEST_TIME_HR would also exist next to
> REQUEST_TIME and REQUEST_TIME_FLOAT



Hi :)

The idea sounds reasonable on the face of it.

Are there any performance issues calling hrtime on every request (possibly
platform-specific)?

I note that the existing values are not fetched directly from a time
source, but have some logic for SAPIs to provide a value [1] e.g. from the
Apache request context [2], and then REQUEST_TIME is just
REQUEST_TIME_FLOAT truncated to integer.

Should the same approach happen here? e.g. should all three values be based
on hrtime if the SAPI does not provide a value? Would we even need an extra
value if REQUEST_TIME_FLOAT had enough precision?

[1] https://heap.space/xref/php-src/main/SAPI.c?r=9d5f2f13#1085
[2]
https://heap.space/xref/php-src/sapi/apache2handler/sapi_apache2.c?r=4da0da7f#371

Regards,
-- 
Rowan Tommins
[IMSoP]

--000000000000308bc805f9224352--