Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:11994
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Date: Sat, 7 Aug 2004 17:02:17 +0100
To: internals@lists.php.net
Message-ID: <20040807160217.GA15321@redhat.com>
Mail-Followup-To: internals@lists.php.net
References: <20040723211815.GB15309@redhat.com> <Pine.LNX.4.58.0408021054261.1621@localhost>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <Pine.LNX.4.58.0408021054261.1621@localhost>
User-Agent: Mutt/1.4.1i
Subject: Re: [PHP-DEV] [PATCH] fix symbol namespace pollution from bundled libgd
From: jorton@redhat.com (Joe Orton)

On Mon, Aug 02, 2004 at 10:55:27AM +0200, Derick Rethans wrote:
> On Fri, 23 Jul 2004, Joe Orton wrote:
> 
> > Building the bundled libgd library into PHP causes symbol namespace
> > pollution; if any other Apache modules link a different version of libgd
> > into the Apache process they may instead pick up symbols from the PHP
> > libgd, and segfault randomly.  (One of our users saw this when using
> > mod_perl with Perl::GD)
> 
> Hmm, I don't really like this "hiding" of symbol names. Why just not fix
> our bundled GD to use the correct names?

That would mean adding exactly the reverse set of #defines to allow the
the GD extension to be built against an external copy of libgd (which of
course won't use the phpgd_* symbols).

Given that a complete set of #defines is needed anyway, doing it without
modifying libgd makes more sense since it's then easier to track the
upstream libgd sources.

joe