Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:119825
MIME-Version: 1.0
In-Reply-To: <GVXPR06MB8972950BC5031756A8F39D5DB2919@GVXPR06MB8972.eurprd06.prod.outlook.com>
References: <GVXPR06MB8972D3FEA5647B021C5775E3B2909@GVXPR06MB8972.eurprd06.prod.outlook.com>
 <CAPyj-LA4p7_tR8xjj4DFKtXtYQsZm34Q_Uq73KGnWr+zeamAEA@mail.gmail.com> <GVXPR06MB8972950BC5031756A8F39D5DB2919@GVXPR06MB8972.eurprd06.prod.outlook.com>
Date: Thu, 6 Apr 2023 23:03:58 +1000
Message-ID: <CAKVXxD8Gr9_-ps6=dLuLA-gnmzVkN2Ku2m3fYX04dOvB5qFrsg@mail.gmail.com>
To: "Vorisek, Michael" <vorismi3@fjfi.cvut.cz>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000b2a87f05f8aa8ac1"
Subject: Re: [PHP-DEV] Array spread append
From: mickmackusa@gmail.com (mickmackusa)

--000000000000b2a87f05f8aa8ac1
Content-Type: text/plain; charset="UTF-8"

>
>
> * Are integer keys preserved? I'm assuming no, as otherwise it would
> be the same as `$a + $b`.
>
> $arr[...] = $arr;
> should be the same as
> foreach ($arr as $v) { $arr[] = $v; }
>
> all other answers should be answered from this and consistency


Since `$arr1[...] = $arr2;` should be consistent with `foreach ($arr2 as
$v) { $arr1[] = $v; }` (or more succinctly with a bodiless loop: `foreach
($arr2 as $arr1[]);`. In this regard, it appears to destroy $arr2 keys
while appending.  So for cases with non-numeric keys that choke the spread
operator within `array_push()`, then the bodiless loop isn't horrific.

What I do find unsettling is that the spread operator in its current
implementations always serves to unpack the payload that follows it (on its
right side). However, in this new implementation, the three dots are
entombed in square braces -- it would be inconsistent with the language.

I think it would be more intuitive to implement an array "appending"
functionality with "concatenating" syntax.  The `.=` syntax already exists,
but is forbidden from use on non-strings.  If you want to implement this
preexisting syntax as an array concatenation operator, then it is a blank
slate -- you can decree whatever behaviors you wish for it without blurring
what the combined operator does with strings.  This opportunity is similar
to how `+=` acts as an addition-assignment operator or an array union
operator depending on context.

I don't think I have an appetite for going down this road, but if so, I
could imagine appending with `$all = $arr1 . $arr2 . $arr3;`  The reason
that I find this unsavory is probably because it becomes harder to intuit a
data type by merely scanning code functionality.  If the variable names
aren't indicative and there is no type hinting, it will be hard to discern
string variables from array variables without more context.

I suppose my parting thought on this discussion is that the spread operator
is just not the best tool for this job -- if this is a job worth doing at
all.

Mick

--000000000000b2a87f05f8aa8ac1--