Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:119820
MIME-Version: 1.0
References: <GVXPR06MB8972D3FEA5647B021C5775E3B2909@GVXPR06MB8972.eurprd06.prod.outlook.com>
 <642DF7C3.2020703@adviesenzo.nl>
In-Reply-To: <642DF7C3.2020703@adviesenzo.nl>
Date: Thu, 6 Apr 2023 01:39:29 +0200
Message-ID: <CAB-Bujbn8UJmEmky+z92G+++GgmLX9ykR+yvRUfaWkivMAksUQ@mail.gmail.com>
To: Juliette Reinders Folmer <php-internals_nospam@adviesenzo.nl>
Cc: internals@lists.php.net
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Array spread append
From: andreas@dqxtech.net (Andreas Hennings)

> I have the feeling I'm missing something, but how would this compare to
array join

Array join does neither append nor replace if a numeric index already exist=
s.
But you can do [...$arr0, ...$arr1].
https://3v4l.org/CIinR

print json_encode([
    [...['a', 'b'], ...['c', 'd']],  // [a, b, c, d]
    array_merge(['a', 'b'], ['c', 'd']),  // [a, b, c, d]
    ['a', 'b'] + ['c', 'd'],  // [a, b]
    array_replace(['a', 'b'], ['c', 'd']),  // [c, d]
]);

(I wish we could use yaml for these outputs)


> $arr[...] =3D $arr2;

Using spread in the array index would be different from current usage
of the spread operator.
But it could be a nice alternative to `$arr =3D [...$arr, $arr2]`, as it
does not require to repeat the first variable.
So I am not against it.


--- Andreas

On Thu, 6 Apr 2023 at 00:36, Juliette Reinders Folmer
<php-internals_nospam@adviesenzo.nl> wrote:
>
> On 6-4-2023 0:12, Vorisek, Michael wrote:
> > Hello,
> >
> > I would like to open a discussion for https://github.com/php/php-src/is=
sues/10791 .
> > [https://opengraph.githubassets.com/a23cb565cc8acac6a33ecab5d9ee68a46f0=
46a1ffe215501673156e506695430/php/php-src/issues/10791]<https://github.com/=
php/php-src/issues/10791>
> > Array spread append =C2=B7 Issue #10791 =C2=B7 php/php-src<https://gith=
ub.com/php/php-src/issues/10791>
> > Description Currently spread operator can be used for almost anything. =
But not for array append. I propose the following to be supported: <?php $a=
rr =3D [1, 2]; $arr2 =3D [3, 4]; $arr[...] =3D $arr2; // ...
> > github.com
> > Appending N elements to an array is quite common language usage pattern=
 and I belive it should be supported natively for shorter syntax, language =
consistency and performance.
> >
> > I am unable to implement it, but I am ready to help with RFC.
> >
> > Michael Vorisek
>
> I have the feeling I'm missing something, but how would this compare to
> array join (which is already available and is actually shorter than this)=
 ?
>
> $arr +=3D $arr2;
>
> Smile,
> Juliette
>
>