Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:11977 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 87739 invoked by uid 1010); 6 Aug 2004 21:12:44 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 87656 invoked from network); 6 Aug 2004 21:12:44 -0000 Received: from unknown (HELO colo.lerdorf.com) (66.198.51.121) by pb1.pair.com with SMTP; 6 Aug 2004 21:12:44 -0000 Received: from rasmus2.corp.yahoo.com (rasmus2.corp.yahoo.com [207.126.233.18]) by colo.lerdorf.com (8.12.11/8.12.11/Debian-5) with ESMTP id i76LChhJ031757; Fri, 6 Aug 2004 14:12:43 -0700 Date: Fri, 6 Aug 2004 14:12:45 -0700 (PDT) X-X-Sender: rasmus@t42p To: Andi Gutmans cc: Sara Golemon , internals@lists.php.net In-Reply-To: <5.1.0.14.2.20040806140026.02cc9ec8@127.0.0.1> Message-ID: References: <5.1.0.14.2.20040724003444.034ea690@127.0.0.1> <5.1.0.14.2.20040724003444.034ea690@127.0.0.1> <5.1.0.14.2.20040725104701.02789d40@127.0.0.1> <5.1.0.14.2.20040806140026.02cc9ec8@127.0.0.1> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Subject: Re: [PHP-DEV] Everyone on the road? From: rasmus@php.net (Rasmus Lerdorf) On Fri, 6 Aug 2004, Andi Gutmans wrote: > If you call it get_request_start_time() it should make it clearer what it > means. > I guess we could put it into SAPI I don't see any disadvantage although in > any case, doing it one more time per-request wouldn't be that bad either. > I hope to have more time towards the end of next week and then I can > hopefully make this improvement. Sure, it's a single syscall, but this entire effort is about removing syscalls, so adding one that isn't necessary because it has already been done during the request makes sense. I am just cleaning up some other code where a sapi call for this would make things a lot cleaner. Without the sapi call you end up needing to do this: #if HAVE_APACHE #include "httpd.h" #endif ... #if HAVE_APACHE t = ((request_rec *)SG(server_context))->request_time; #else t = time(0); #endif -Rasmus