Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:119660
Feedback-ID: i8414410d:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-183-gbf7d00f500-fm-20230220.001-gbf7d00f5
Mime-Version: 1.0
Message-ID: <7e08b0f9-9d30-4ead-8194-2494ecc78e2e@app.fastmail.com>
In-Reply-To: 
 <CAEKnhAGjn54aKAd-GQM7e=OScZJK02+060zRJO-N7r4jAbFHzA@mail.gmail.com>
References: 
 <CANMwmbMObQJD=bBncxXcHOgs1yoBfHXsTE1KZDYcSKMxMUUrRQ@mail.gmail.com>
 <CALKiJKpuDUJ6cyh8DdCFV2o740A3ua+H0nc3_qYHwCrrSdLkGg@mail.gmail.com>
 <CAEKnhAGsAgNxfhGBLRU69HibaFYaeef4NsefxHYOQXyF2ZNSkw@mail.gmail.com>
 <CALKiJKr2nGAZpBEteUMX2EO_8HmX4s_TvVh1FeM3NJdeg=+6Kg@mail.gmail.com>
 <CAEKnhAGjn54aKAd-GQM7e=OScZJK02+060zRJO-N7r4jAbFHzA@mail.gmail.com>
Date: Thu, 02 Mar 2023 14:29:33 -0600
To: "php internals" <internals@lists.php.net>
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] RFC Idea - json_validate() validate schema
From: larry@garfieldtech.com ("Larry Garfield")

On Thu, Mar 2, 2023, at 1:31 PM, Jakub Zelenka wrote:
> On Thu, Mar 2, 2023 at 5:53=E2=80=AFPM Rowan Tommins <rowan.collins@gm=
ail.com>
> wrote:
>
>> On Thu, 2 Mar 2023 at 12:34, Jakub Zelenka <bukka@php.net> wrote:
>>
>> > It's possible that we might decide to stop supporting some drafts i=
f the
>> > maintenance burden is too big and usage small but I wouldn't see th=
at as
>> > something that happens often. But essentially you are right that th=
ere
>> will
>> > be minimum (draft-04 initially) and maximum (latest implemented dra=
ft).
>> >
>>
>>
>> Thinking about this, particularly if there is the ability to install =
a PECL
>> extension which supports different versions from the core PHP version,
>> perhaps it would be useful to expose a function or constant that list=
s the
>> supported versions, so that code needing a particular version could c=
heck
>> for support directly, rather than having to attempt and catch an exce=
ption?
>>
>>
> That's a good point. I think a constant should be sufficient. I think =
the
> different classes make less sense if $schema is specified as I would t=
hink
> that the $schema should have a priority. So having just default argume=
nt
> using the constant for the cases where it's not specified should be
> sufficient IMHO.
>
> Cheers
>
> Jakub

You mean using the version from the JSON string, and allowing an overrid=
e?  Like this?

new JsonSchema($schema_string, version: JsonSchema::DRAFT_4);

I see two issues there.

1. If I want to see if DRAFT_6 is available, I have to use defined()[1] =
with strings.  This is fugly.

2. I don't know how to polyfill newer spec versions if I don't want to w=
ait for internals to get around to adding a new version.

--Larry Garfield

[1] https://www.php.net/manual/en/function.defined