Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:119644
Feedback-ID: i8414410d:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-183-gbf7d00f500-fm-20230220.001-gbf7d00f5
Mime-Version: 1.0
Message-ID: <49d276f7-cfe9-4d9a-b225-9706986a4996@app.fastmail.com>
In-Reply-To: 
 <CAEKnhAE7BSrXBv-4BQCVTSemmY1Z2XMTuj5nhv85mrSytnHvqw@mail.gmail.com>
References: 
 <CANMwmbMObQJD=bBncxXcHOgs1yoBfHXsTE1KZDYcSKMxMUUrRQ@mail.gmail.com>
 <CAEKnhAE7BSrXBv-4BQCVTSemmY1Z2XMTuj5nhv85mrSytnHvqw@mail.gmail.com>
Date: Wed, 01 Mar 2023 11:04:27 -0600
To: "php internals" <internals@lists.php.net>
Content-Type: text/plain
Subject: Re: [PHP-DEV] RFC Idea - json_validate() validate schema
From: larry@garfieldtech.com ("Larry Garfield")

On Wed, Mar 1, 2023, at 6:06 AM, Jakub Zelenka wrote:
> On Wed, Mar 1, 2023 at 11:44 AM juan carlos morales <
> dev.juan.morales@gmail.com> wrote:
>
>> Hello Internals.
>>
>> I am thinking about improving the json_validate() function developed
>> for php 8.3.
>>
>> The actual descriptions goes like this:
>>
>> json_validate(string $json, int $depth = 512, int $flags = 0): bool
>>
>> I am thinking about enhancing this function to also be able to
>> validate against a JSON SCHEMA, giving us something like this:
>>
>> json_validate(string $json, int $depth = 512, int $flags = 0, string
>> $json_schema = null): bool
>>
>> so, if the string is a valid JSON and also respects the schema ... then
>> TRUE.
>>
>> What do you think ?
>>
>>
> I'm actually working on this. Currently developing the schema parsing in
> pure C implementation in my play C tool called jso. You can see progress
> here: https://github.com/bukka/jso/commits/next . The plan is to develop it
> inside jso and then port it to jsond and then propose it for json ext
> inclusion (that's how I developed the current parser). There is a lot of to
> do as JsonSchema is quite complex (composition, JSON pointers, stream
> integration for external pointers and more tricky bits) so this won't
> likely be ready for 8.3 but should be ready for 8.4. I plan to introduce
> some smaller things for 8.3 like better error reporting (error location
> which I have already working in jso) and some other small additions. By the
> way, the schema support won't be useful just for validation but also for
> decoding and possibly encoding (sort of replacement for JsonSerializable).
> Especially for decoding it can be further extended to allow class mapping.
> We could also provide automatic generation of schema from class and support
> attributes. I plan to propose all of this later as well but that might take
> some time.
>
> Regards
>
> Jakub

Ooo...  This would be super userful, especially for some of the ideas I have floating about in the back of my head for new libraries. :-)  I'm no help on the C implementation side but I'd be happy to collaborate on the user-space API design.  That's something we'd want to get very-right the first time out, or else have just the primitives that allow us to do the not-slow bits in user-space.  (Which will likely mean something more than just tacking an extra parameter onto json_validate().)

--Larry Garfield