Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:119627 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 62773 invoked from network); 1 Mar 2023 05:37:41 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 1 Mar 2023 05:37:41 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 3393C180084 for ; Tue, 28 Feb 2023 21:37:36 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS24940 138.201.0.0/16 X-Spam-Virus: No X-Envelope-From: Received: from swift.blarg.de (swift.blarg.de [138.201.185.127]) by php-smtp4.php.net (Postfix) with ESMTP for ; Tue, 28 Feb 2023 21:37:35 -0800 (PST) Received: from swift.blarg.de (swift.blarg.de [IPv6:2a01:4f8:c17:52a8::2]) (Authenticated sender: max) by swift.blarg.de (Postfix) with ESMTPSA id 8A99241211; Wed, 1 Mar 2023 06:37:33 +0100 (CET) Date: Wed, 1 Mar 2023 06:37:32 +0100 To: Dmitry Stogov Cc: PHP Internals Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [PHP-DEV] PHP code refactoring (was: include cleanup) From: max+php@blarg.de (Max Kellermann) On 2023/02/28 23:33, Max Kellermann wrote: > > Include cleanups RFC was rejected. > > No refactoring RFC was presented. > > A lot of changes that affect all core contributors are committed into > > master. > > Do you mean to imply that code changes that do not implement RFC or > fix a bug should always be rejected? CONTRIBUTING.md says: "PHP welcomes pull requests to add tests, fix bugs and to implement RFCs." Indeed it appears Dmitry is right - code refactoring is generally NOT allowed (unless there is an explicit RFC vote, and I havn't seen one). This implies that all those commits (and hundreds of others): > https://github.com/php/php-src/commit/4177257178d6a1a44f0aa6d6b23d02b91e0a58d3 > https://github.com/php/php-src/commit/9108a32bfe881c3b1e2f3b2949b0e9fe1b9c6dda > https://github.com/php/php-src/commit/07fe46fb5db9d6f34e72f513ae053fc8c9ad67a > https://github.com/php/php-src/commit/900472536775b71d5d72a0d66eaa46ae7c7d7ad9 > https://github.com/php/php-src/commit/f0cfebc2b867a6a96a88c4526cf9f3b4cd01f04b > https://github.com/php/php-src/commit/f079aa2e242b251c6297bddf5365c33c126b7dcc > https://github.com/php/php-src/commit/b14dd85dca3b67a5462f5ed9b6aa0dc22beb615c ... should not have been merged! Where do we go from here? Really revert EVERYTHING? (Reverting just my code refactoring changes but nobody else's would make no sense at all. Don't make this personal.) Max