Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:119623
Feedback-ID: id4a9467a:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-183-gbf7d00f500-fm-20230220.001-gbf7d00f5
Mime-Version: 1.0
Message-ID: <f6f58d75-0d93-44bc-bee6-a34b086a53d8@app.fastmail.com>
In-Reply-To: <Y/5+fpzShcinX1jt@swift.blarg.de>
References: 
 <CAPVMwwvRyE7+XUHoQ=p=HBKdFrc7FaCAB52hyNzr79hLdhcZqQ@mail.gmail.com>
 <CAMXcktNPc82ZpTKoteDu5ePQ++Fn8KUzjarMqrVFKaTxugZTmQ@mail.gmail.com>
 <CAPVMwwvCpG+k7EuZwjL4zbwgzV-88PoZmuRUPW9bPx8mq9qppg@mail.gmail.com>
 <Y/5+fpzShcinX1jt@swift.blarg.de>
Date: Tue, 28 Feb 2023 23:37:38 +0100
To: "PHP internals list" <internals@lists.php.net>
Content-Type: multipart/alternative;
 boundary=f17794fb1b4e463399d50286a75ac47d
Subject: Re: [PHP-DEV] PHP code refactoring (was: include cleanup)
From: nikita.ppv@gmail.com ("Nikita Popov")

--f17794fb1b4e463399d50286a75ac47d
Content-Type: text/plain

I'm a bit out of the loop on the higher level discussion, but as I got named dropped here, a quick note...

On Tue, Feb 28, 2023, at 23:21, Max Kellermann wrote:
> On 2023/02/28 22:31, Dmitry Stogov <dmitrystogov@gmail.com> wrote:
> > https://github.com/php/php-src/commit/0270a1e54c0285fa3c89ee2b0120073ef57ab5fa
> 
> This kind of change was favored by a supermajority.
> 
> You argue that this supermajority vote is irrelevant, and formally it
> indeed is, but pondering about formalities is kind of ignorant against
> the now well-known community opinion.
> 
> > https://github.com/php/php-src/commit/b98f18e7c3838cf587a1b6d0f033b89e9909c79d
> 
> No vote was made on this, therefore this doesn't violate any community
> rules, does it?
> 
> If you think this should be reverted, explain why.
> 
> > https://github.com/php/php-src/commit/42577c6b6b7577c57c161ee4a74cb193382bf1e0
> 
> Favored by supermajority, see above.
> 
> > https://github.com/php/php-src/commit/c7637ed1c03f556c6fb65884cfc5bfea4920b1c7
> 
> No vote, no rule violation, see above.

This commit broke a valuable debugging reference: I used to often check these defines to determine what a type code means. If you get type 18, good luck figuring out what that means now.

> 
> > https://github.com/php/php-src/commit/371ae12d890f1887f79b7e2a32f808b4595e5f60
> 
> As you see in the commit message, this implements an (unwritten) rule
> cited by Nikita Popov (which is now written as of
> https://github.com/php/php-src/pull/10630).  I personally don't agree
> with this rule (there's a thread on this mailing list about it), and I
> would favor reverting this commit - I only submitted this trying to
> help with implementing a rule even though I don't agree with it.

This is a pretty cherry-picked statement. In that mailing list thread I explicitly pointed out that while this is the rule (and if you introduce new code, that would be the convention to follow), that does not necessarily mean that it's a good idea to fix existing cases that don't follow it. I also pointed out that for public APIs, this is a very insidious API break, because it doesn't make using code fail to compile: It just silently inverts the result from it's previous meaning. It looks like those parts of my mail just got ignored.

Regards,
Nikita

> If this gets reverted, then https://github.com/php/php-src/pull/10630
> should be reverted as well.  Again, not my opinion, I'm just trying to
> help implement somebody else's opinion.
> 
> Max
> 
> -- 
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: https://www.php.net/unsub.php
> 
> 

--f17794fb1b4e463399d50286a75ac47d--