Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:119621
MIME-Version: 1.0
References: <CAPVMwwvRyE7+XUHoQ=p=HBKdFrc7FaCAB52hyNzr79hLdhcZqQ@mail.gmail.com>
 <CAMXcktNPc82ZpTKoteDu5ePQ++Fn8KUzjarMqrVFKaTxugZTmQ@mail.gmail.com>
 <CAPVMwwvCpG+k7EuZwjL4zbwgzV-88PoZmuRUPW9bPx8mq9qppg@mail.gmail.com> <Y/5+fpzShcinX1jt@swift.blarg.de>
In-Reply-To: <Y/5+fpzShcinX1jt@swift.blarg.de>
Date: Wed, 1 Mar 2023 01:34:14 +0300
Message-ID: <CAPVMwwtJeD-QGo3JWqk_hNT2p+5CAF_u+_bTR5MZwMU0uA1zRA@mail.gmail.com>
To: Max Kellermann <max+php@blarg.de>
Cc: Dan Liebner <dliebner@gmail.com>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000ac171c05f5ca3212"
Subject: Re: [PHP-DEV] PHP code refactoring (was: include cleanup)
From: dmitrystogov@gmail.com (Dmitry Stogov)

--000000000000ac171c05f5ca3212
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 1, 2023 at 1:21=E2=80=AFAM Max Kellermann <max+php@blarg.de> wr=
ote:

> On 2023/02/28 22:31, Dmitry Stogov <dmitrystogov@gmail.com> wrote:
> >
> https://github.com/php/php-src/commit/0270a1e54c0285fa3c89ee2b0120073ef57=
ab5fa
>
> This kind of change was favored by a supermajority.
>
> You argue that this supermajority vote is irrelevant, and formally it
> indeed is, but pondering about formalities is kind of ignorant against
> the now well-known community opinion.
>
> >
> https://github.com/php/php-src/commit/b98f18e7c3838cf587a1b6d0f033b89e990=
9c79d
>
> No vote was made on this, therefore this doesn't violate any community
> rules, does it?
>

Please reread https://wiki.php.net/RFC/voting#voting
RFC is accepted by a supermajority of the primary vote.
The secondary votes may be used to make decisions about implementation
details.

Thanks. Dmitry.


>
> If you think this should be reverted, explain why.
>
> >
> https://github.com/php/php-src/commit/42577c6b6b7577c57c161ee4a74cb193382=
bf1e0
>
> Favored by supermajority, see above.
>
> >
> https://github.com/php/php-src/commit/c7637ed1c03f556c6fb65884cfc5bfea492=
0b1c7
>
> No vote, no rule violation, see above.
>
> >
> https://github.com/php/php-src/commit/371ae12d890f1887f79b7e2a32f808b4595=
e5f60
>
> As you see in the commit message, this implements an (unwritten) rule
> cited by Nikita Popov (which is now written as of
> https://github.com/php/php-src/pull/10630).  I personally don't agree
> with this rule (there's a thread on this mailing list about it), and I
> would favor reverting this commit - I only submitted this trying to
> help with implementing a rule even though I don't agree with it.
>
> If this gets reverted, then https://github.com/php/php-src/pull/10630
> should be reverted as well.  Again, not my opinion, I'm just trying to
> help implement somebody else's opinion.
>
> Max
>

--000000000000ac171c05f5ca3212--