Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:119619 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 33312 invoked from network); 28 Feb 2023 22:21:55 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 28 Feb 2023 22:21:55 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 54A6B1804F8 for ; Tue, 28 Feb 2023 14:21:53 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS24940 138.201.0.0/16 X-Spam-Virus: No X-Envelope-From: Received: from swift.blarg.de (swift.blarg.de [138.201.185.127]) by php-smtp4.php.net (Postfix) with ESMTP for ; Tue, 28 Feb 2023 14:21:52 -0800 (PST) Received: from swift.blarg.de (swift.blarg.de [IPv6:2a01:4f8:c17:52a8::2]) (Authenticated sender: max) by swift.blarg.de (Postfix) with ESMTPSA id 7842040F72; Tue, 28 Feb 2023 23:21:51 +0100 (CET) Date: Tue, 28 Feb 2023 23:21:50 +0100 To: Dmitry Stogov Cc: Dan Liebner , PHP Internals Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [PHP-DEV] PHP code refactoring (was: include cleanup) From: max+php@blarg.de (Max Kellermann) On 2023/02/28 22:31, Dmitry Stogov wrote: > https://github.com/php/php-src/commit/0270a1e54c0285fa3c89ee2b0120073ef57ab5fa This kind of change was favored by a supermajority. You argue that this supermajority vote is irrelevant, and formally it indeed is, but pondering about formalities is kind of ignorant against the now well-known community opinion. > https://github.com/php/php-src/commit/b98f18e7c3838cf587a1b6d0f033b89e9909c79d No vote was made on this, therefore this doesn't violate any community rules, does it? If you think this should be reverted, explain why. > https://github.com/php/php-src/commit/42577c6b6b7577c57c161ee4a74cb193382bf1e0 Favored by supermajority, see above. > https://github.com/php/php-src/commit/c7637ed1c03f556c6fb65884cfc5bfea4920b1c7 No vote, no rule violation, see above. > https://github.com/php/php-src/commit/371ae12d890f1887f79b7e2a32f808b4595e5f60 As you see in the commit message, this implements an (unwritten) rule cited by Nikita Popov (which is now written as of https://github.com/php/php-src/pull/10630). I personally don't agree with this rule (there's a thread on this mailing list about it), and I would favor reverting this commit - I only submitted this trying to help with implementing a rule even though I don't agree with it. If this gets reverted, then https://github.com/php/php-src/pull/10630 should be reverted as well. Again, not my opinion, I'm just trying to help implement somebody else's opinion. Max