Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:119617
MIME-Version: 1.0
References: <CAPVMwwvRyE7+XUHoQ=p=HBKdFrc7FaCAB52hyNzr79hLdhcZqQ@mail.gmail.com>
 <CAMXcktNPc82ZpTKoteDu5ePQ++Fn8KUzjarMqrVFKaTxugZTmQ@mail.gmail.com>
In-Reply-To: <CAMXcktNPc82ZpTKoteDu5ePQ++Fn8KUzjarMqrVFKaTxugZTmQ@mail.gmail.com>
Date: Wed, 1 Mar 2023 00:31:22 +0300
Message-ID: <CAPVMwwvCpG+k7EuZwjL4zbwgzV-88PoZmuRUPW9bPx8mq9qppg@mail.gmail.com>
To: Dan Liebner <dliebner@gmail.com>
Cc: PHP Internals <internals@lists.php.net>, Max Kellermann <max+php@blarg.de>
Content-Type: multipart/alternative; boundary="000000000000cdb15b05f5c9514a"
Subject: Re: [PHP-DEV] PHP code refactoring (was: include cleanup)
From: dmitrystogov@gmail.com (Dmitry Stogov)

--000000000000cdb15b05f5c9514a
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Feb 28, 2023 at 11:59=E2=80=AFPM Dan Liebner <dliebner@gmail.com> w=
rote:

> Which commit?
>

just some of them:
https://github.com/php/php-src/commit/0270a1e54c0285fa3c89ee2b0120073ef57ab=
5fa
https://github.com/php/php-src/commit/b98f18e7c3838cf587a1b6d0f033b89e9909c=
79d
https://github.com/php/php-src/commit/42577c6b6b7577c57c161ee4a74cb193382bf=
1e0
https://github.com/php/php-src/commit/c7637ed1c03f556c6fb65884cfc5bfea4920b=
1c7
https://github.com/php/php-src/commit/371ae12d890f1887f79b7e2a32f808b4595e5=
f60

Thanks. Dmitry.


>
> On Tue, Feb 28, 2023, 3:17 PM Dmitry Stogov <dmitrystogov@gmail.com>
> wrote:
>
>> Hi @internals,
>>
>> I have to say that we came to a serious conflict.
>>
>> Recently we voted for inluce cleanup RFC
>> https://wiki.php.net/rfc/include_cleanup and it was declined.
>> Despite that a series of code refactoring commits from Max were silently
>> merged into the master.
>> As this is a violation of the community rules and we should do something=
.
>> In my opinion, this should be reverted (I would even think about rebasin=
g
>> to not pollute the git history).
>>
>> Personally, I don't like this refactoring, because it is mainly about
>> coding preferences and habits.
>> Anyway, I see that some people like this. Maybe this may attract new
>> developers.
>>
>> OK. Let's do this, but do this in a managed way. The massive uncontrolle=
d
>> changes is the main problem in the current situation.
>> Let's define the goal(s), rules, make a plan, summarize this in a new RF=
C,
>> accept it.
>> Then most of the work should be done in a separate branch and merged int=
o
>> the master all together after a final review.
>> I (and other authority contributors) wouldn't be able to object against
>> the
>> terms accepted in RFC.
>> So a good RFC should be a half of success...
>> It would be great if PHP Foundation could assign some experienced
>> developer(s) to be part of this work.
>>
>> Thanks. Dmitry.
>>
>

--000000000000cdb15b05f5c9514a--