Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:119616 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 26929 invoked from network); 28 Feb 2023 21:30:26 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 28 Feb 2023 21:30:26 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id A2CCE180504 for ; Tue, 28 Feb 2023 13:30:24 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS15623 212.45.192.0/19 X-Spam-Virus: No X-Envelope-From: Received: from mail.gna.ch (mail.gna.ch [212.45.196.109]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Tue, 28 Feb 2023 13:30:24 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by darkcity.gna.ch (Postfix) with ESMTP id 9175D3A1D95 for ; Tue, 28 Feb 2023 22:30:22 +0100 (CET) X-Virus-Scanned: amavisd-new at example.com Received: from mail.gna.ch ([127.0.0.1]) by localhost (darkcity.gna.ch [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gDykda8HUKtO for ; Tue, 28 Feb 2023 22:30:21 +0100 (CET) Received: from smtpclient.apple (unknown [IPv6:2a02:1210:2ea4:cf00:a106:316a:edf2:6be0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by darkcity.gna.ch (Postfix) with ESMTPSA id 9BDB03A1D94 for ; Tue, 28 Feb 2023 22:30:21 +0100 (CET) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.400.51.1.1\)) Date: Tue, 28 Feb 2023 22:30:21 +0100 References: To: PHP Internals In-Reply-To: Message-ID: <222A9590-605B-44D3-8513-3B8A1C5A8B99@cschneid.com> X-Mailer: Apple Mail (2.3731.400.51.1.1) Subject: Re: [PHP-DEV] PHP code refactoring (was: include cleanup) From: cschneid@cschneid.com (Christian Schneider) Am 28.02.2023 um 22:04 schrieb Max Kellermann : > On 2023/02/28 21:16, Dmitry Stogov wrote: >> Recently we voted for inluce cleanup RFC >> https://wiki.php.net/rfc/include_cleanup and it was declined. >=20 > Which specific commits do you wish to revert? Is this about include > cleanups (none of which were merged) or about header splitting (which > a supermajority voted for) or about other kinds of code refactoring > (which was not voted on)? You keep saying that people voted yes on the secondary vote = (clarifications on how to clean up). Just to clarify: This is irrelevant as the primary vote was declined. > My opinion is: if a patch improves a piece of code, it should be > merged. Of course, whether something is an improvement is debatable; > but postponing that decision is pointless and harmful. As far as I can see there seems to be a disagreement whether it is an = improvement, which to me sounds like there must be more discussion. = Which means the decision has to be postponed, no? I second Dmitry's request to do things in a managed way. What exactly caused the disruption I'm not sure and it is not about = blaming someone but finding a workable solution. Regards, - Chris