Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:119614 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 22798 invoked from network); 28 Feb 2023 20:59:28 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 28 Feb 2023 20:59:28 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id F0995180547 for ; Tue, 28 Feb 2023 12:59:27 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS15169 209.85.128.0/17 X-Spam-Virus: No X-Envelope-From: Received: from mail-yw1-f182.google.com (mail-yw1-f182.google.com [209.85.128.182]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Tue, 28 Feb 2023 12:59:24 -0800 (PST) Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-536b7ffdd34so309942787b3.6 for ; Tue, 28 Feb 2023 12:59:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677617964; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=p0LRFc4kt7HA5GbaW8sZgN3BaUOtfF0w8vA4yuLKV2E=; b=mI5P80jwVLfqS/ZxDZ8GZgRoqrrV9J6NHd97j8kN1ywaqxLc426Vru/I9FYqTO44Kq u7ilae69V/TXL8hkWKzoCx6TeSOPkfnUhcZxv5onIU2XvzuBF048SFqMEPgVHswmxoqM KJ4D2IoQ3uzQGJtvJGbDtScAxnxVKx6NFL2QktvG1NqKPAgsYN7G/GfwFJPAP0PGqLL+ dxiXofGVKeC/cVwSGzVZA2k8ATKtEoJ1SBCR6anhrOvPLGivqZyo9kb8czjAzDb+e3H4 a8EMOqa0f1ifF7YNnhh1+fLn8iCh2sqFcpNQs/jeC5+wRPXDkkeHQ1XdHRAxPpfuFm2G Izog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677617964; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=p0LRFc4kt7HA5GbaW8sZgN3BaUOtfF0w8vA4yuLKV2E=; b=glxcbTEfjajS1meaMt1wv2YzWTV1fkDt6j/b5x3gq/gSe3dW1Kaybtmu/wz4BhU4nu ok988abkkd/hoeSPVMY9K+Ly14LkeAZFLdTw4Mppejc8NZPueJNm642opBABO4yXLd+f tlbfdJC7zHRfkPug7kkUNamr92TxB/8Q4w/Rf6X4r0nkQUoNIloOUtZDyiygRelw6i8Z xRafwC4QLtzqLgduunFRRwcXH9YVjvn+Fg4C/JZLWTJzc7zyjOH/v3QqOQNlRQXHba6z tDi/VjCyb+S+EpAIyOlvt3tEqsBrK97P2tMkHW8MX/dHsNSDCdoXp0BFKliIJGR02IPD OWsQ== X-Gm-Message-State: AO0yUKVWsJTm8R4l3oSm2whpCfCRdnPUys1wPEL0WwLISsrNjtRiJS1b IL1qK/wMK6MZ8OtWq2g/UtybOWc30JMevPY/ubw= X-Google-Smtp-Source: AK7set8HGvQ1wz8TdiiUbMFsIEgA7xKskeFKegjtK3+1jjSstuon2FcwKDN6cc0XlqiwHhlGFIk3fTtRL0ByjL2Q7bc= X-Received: by 2002:a25:9c46:0:b0:a1e:deda:9c95 with SMTP id x6-20020a259c46000000b00a1ededa9c95mr2189782ybo.4.1677617963697; Tue, 28 Feb 2023 12:59:23 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: Date: Tue, 28 Feb 2023 15:59:12 -0500 Message-ID: To: Dmitry Stogov Cc: PHP Internals , Max Kellermann Content-Type: multipart/alternative; boundary="000000000000cb8c4d05f5c8de83" Subject: Re: [PHP-DEV] PHP code refactoring (was: include cleanup) From: dliebner@gmail.com (Dan Liebner) --000000000000cb8c4d05f5c8de83 Content-Type: text/plain; charset="UTF-8" Which commit? On Tue, Feb 28, 2023, 3:17 PM Dmitry Stogov wrote: > Hi @internals, > > I have to say that we came to a serious conflict. > > Recently we voted for inluce cleanup RFC > https://wiki.php.net/rfc/include_cleanup and it was declined. > Despite that a series of code refactoring commits from Max were silently > merged into the master. > As this is a violation of the community rules and we should do something. > In my opinion, this should be reverted (I would even think about rebasing > to not pollute the git history). > > Personally, I don't like this refactoring, because it is mainly about > coding preferences and habits. > Anyway, I see that some people like this. Maybe this may attract new > developers. > > OK. Let's do this, but do this in a managed way. The massive uncontrolled > changes is the main problem in the current situation. > Let's define the goal(s), rules, make a plan, summarize this in a new RFC, > accept it. > Then most of the work should be done in a separate branch and merged into > the master all together after a final review. > I (and other authority contributors) wouldn't be able to object against the > terms accepted in RFC. > So a good RFC should be a half of success... > It would be great if PHP Foundation could assign some experienced > developer(s) to be part of this work. > > Thanks. Dmitry. > --000000000000cb8c4d05f5c8de83--