Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:119613
MIME-Version: 1.0
Date: Tue, 28 Feb 2023 23:16:58 +0300
Message-ID: <CAPVMwwvRyE7+XUHoQ=p=HBKdFrc7FaCAB52hyNzr79hLdhcZqQ@mail.gmail.com>
To: PHP Internals <internals@lists.php.net>, Max Kellermann <max+php@blarg.de>
Content-Type: multipart/alternative; boundary="000000000000b6089c05f5c847be"
Subject: [PHP-DEV] PHP code refactoring (was: include cleanup)
From: dmitrystogov@gmail.com (Dmitry Stogov)

--000000000000b6089c05f5c847be
Content-Type: text/plain; charset="UTF-8"

Hi @internals,

I have to say that we came to a serious conflict.

Recently we voted for inluce cleanup RFC
https://wiki.php.net/rfc/include_cleanup and it was declined.
Despite that a series of code refactoring commits from Max were silently
merged into the master.
As this is a violation of the community rules and we should do something.
In my opinion, this should be reverted (I would even think about rebasing
to not pollute the git history).

Personally, I don't like this refactoring, because it is mainly about
coding preferences and habits.
Anyway, I see that some people like this. Maybe this may attract new
developers.

OK. Let's do this, but do this in a managed way. The massive uncontrolled
changes is the main problem in the current situation.
Let's define the goal(s), rules, make a plan, summarize this in a new RFC,
accept it.
Then most of the work should be done in a separate branch and merged into
the master all together after a final review.
I (and other authority contributors) wouldn't be able to object against the
terms accepted in RFC.
So a good RFC should be a half of success...
It would be great if PHP Foundation could assign some experienced
developer(s) to be part of this work.

Thanks. Dmitry.

--000000000000b6089c05f5c847be--