Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:119597 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 79768 invoked from network); 23 Feb 2023 04:53:13 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 23 Feb 2023 04:53:13 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 83CB8180504 for ; Wed, 22 Feb 2023 20:53:12 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS15169 209.85.128.0/17 X-Spam-Virus: No X-Envelope-From: Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Wed, 22 Feb 2023 20:53:11 -0800 (PST) Received: by mail-pl1-f169.google.com with SMTP id u14so7533267ple.7 for ; Wed, 22 Feb 2023 20:53:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=amfIiHKDiWoQ4yR9K+CL6wYbXc3F4BptkDGx3j9Qhf0=; b=YMeCaQ39jy4ADiqOyky7BoUrzLtH4RCNhWaV9mg9t7auiNTKaS7T1ylF8xDaWFzYwy 4t/YNJw7gj6FJrqvWLZARWL10zPdXyD5tsD5BWZ2w3Pu+/k+miN+UIJMxxFqzxT4oTAi NCzzc9LyG8KqYUS+DxiERp7RX9Ih6AXfo8uBPCSHw5wlKjNXc1t/LgqjHpzxV6q3crQc W0W1E3yK8L/LNYzYiKo4dUjZxbBg15V+nBDvycCjpjf6kxSvJEcIHlLh5TkGXsvw0CXR V7Gp4mMaOfzKqEzabiZCQGQmB6A271AzEdTxR11Hs9T93ZS6f6s24ytXHt5aiGaXEetH Utwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=amfIiHKDiWoQ4yR9K+CL6wYbXc3F4BptkDGx3j9Qhf0=; b=XTWVHeq+xQFv5w7a5DpA9GC/DyNHRzwZkGVZt9CDlntPUQM0sFClt1UW7Ns108dzdU gMHNEL97v6YhuTcX69DvfLZ+VSRUt1pXmofZz1r/yl/MeYYj8Bx/rKXylRqg1V9YFgcA yoXhI5foz71dxdPSdCJVfGLkhpDgYHd/6G8OriXHyo9w2cydQsupHB0ca+5JsyK+Ym8V gMjpza7Hmbhh/3X2Q405p7Q1WSnmyMbffT5+WWkq7aEqyj98c5RELD59ViLRRSZKpjEI leS2d1d0gDOrZ5jvDAUjZIv+7reNQo+CpvEp8Nu/L1uIxl5uSiW6RmYHbxl45ZvMcdBL K+KQ== X-Gm-Message-State: AO0yUKWeiLQZpTADxHaoncAIPrFl79Lzy1mHMGR4fxQvEym46WXu5GWr KEX9hQX0kMKpHvU3wvg5/YQ5gjE6e/0N X-Google-Smtp-Source: AK7set+OuQaGPmkB/R1gJWBU9WG0iZcyVDY6oddsBBayIoMNDCPRXAdoH+fx9CNWobJWIJptU7derQ== X-Received: by 2002:a05:6a20:24a7:b0:bc:8254:ddff with SMTP id m39-20020a056a2024a700b000bc8254ddffmr8338404pzd.1.1677127990132; Wed, 22 Feb 2023 20:53:10 -0800 (PST) Received: from [10.230.0.28] (ec2-44-226-106-152.us-west-2.compute.amazonaws.com. [44.226.106.152]) by smtp.gmail.com with ESMTPSA id w4-20020aa78584000000b005a8cc32b23csm2738319pfn.20.2023.02.22.20.53.08 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Feb 2023 20:53:09 -0800 (PST) Message-ID: <607b7a66-bf47-de99-f51a-6cd367e2a839@gmail.com> Date: Wed, 22 Feb 2023 21:53:07 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.7.2 Content-Language: en-US To: internals@lists.php.net References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] LDFLAGS broken? From: smalyshev@gmail.com (Stanislav Malyshev) Hi! >> There seems to be another unset done to this change here: >> https://github.com/php/php-src/commit/c4d84aa33390045cd4ff542719a0f79cff52fb7c >> which fixed some bugs related to linker errors and duplicate symbols. > > Smells like people doing random things until some bug disappears... > and no commit messages here either, no explanation for the change. Are you familiar with the principle called "Chesterton's fence"? It could be these changes do not make sense. It also could be they are necessary for the build to work on one of dozens of systems, distros and tools combinations PHP is being built on. Unless you have tested on all of them, I'd advise caution there. -- Stas Malyshev smalyshev@gmail.com