Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:119596 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 78292 invoked from network); 23 Feb 2023 04:46:08 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 23 Feb 2023 04:46:08 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id F3885180506 for ; Wed, 22 Feb 2023 20:46:04 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS24940 138.201.0.0/16 X-Spam-Virus: No X-Envelope-From: Received: from swift.blarg.de (swift.blarg.de [138.201.185.127]) by php-smtp4.php.net (Postfix) with ESMTP for ; Wed, 22 Feb 2023 20:46:04 -0800 (PST) Received: from swift.blarg.de (swift.blarg.de [IPv6:2a01:4f8:c17:52a8::2]) (Authenticated sender: max) by swift.blarg.de (Postfix) with ESMTPSA id B75BA4118A; Thu, 23 Feb 2023 05:46:01 +0100 (CET) Date: Thu, 23 Feb 2023 05:46:00 +0100 To: Peter Kokot Cc: internals@lists.php.net Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [PHP-DEV] LDFLAGS broken? From: max+php@blarg.de (Max Kellermann) On 2023/02/22 22:09, Peter Kokot wrote: > >From my quick check, the unset is initially done to move the currently > set flags to extra flags variable and clean the variable for further > additions so there are no duplicate ones or something like that. > https://github.com/php/php-src/commit/9417570dc1f31a0e3ddb9f6736a547c87ce7cfba > > There seems to be another unset done to this change here: > https://github.com/php/php-src/commit/c4d84aa33390045cd4ff542719a0f79cff52fb7c > which fixed some bugs related to linker errors and duplicate symbols. Smells like people doing random things until some bug disappears... and no commit messages here either, no explanation for the change. > Most likely, some of those three unset lines could be removed today, > yes, but I can't be sure. If removal would fix some bug, then probably > it is time to remove them and see where things break afterwards. Yes, it fixes bugs. Once my other build system improvement PRs are merged (the CFLAGS mess), I'll submit a patch to fix the LDFLAGS mess. Max