Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:119594 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 27918 invoked from network); 22 Feb 2023 13:14:12 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 22 Feb 2023 13:14:12 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 4ABA3180083 for ; Wed, 22 Feb 2023 05:14:11 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS24940 138.201.0.0/16 X-Spam-Virus: No X-Envelope-From: Received: from swift.blarg.de (swift.blarg.de [138.201.185.127]) by php-smtp4.php.net (Postfix) with ESMTP for ; Wed, 22 Feb 2023 05:14:10 -0800 (PST) Received: from swift.blarg.de (swift.blarg.de [IPv6:2a01:4f8:c17:52a8::2]) (Authenticated sender: max) by swift.blarg.de (Postfix) with ESMTPSA id 9180B41086 for ; Wed, 22 Feb 2023 14:14:09 +0100 (CET) Date: Wed, 22 Feb 2023 14:14:08 +0100 To: internals@lists.php.net Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [PHP-DEV] LDFLAGS broken? From: max+php@blarg.de (Max Kellermann) On 2023/02/22 13:45, Max Kellermann wrote: > 13 years ago, there was commit > https://github.com/php/php-src/commit/477649cd3f09 which attempted to > fix this, but was reverted on the same day by commit > https://github.com/php/php-src/commit/16450418b188 with just commit > message "Revert bad patch" but nothing else, no explanation what was > bad about the patch. Oh look, there was an "edit war" with a bunch of commits repeatedly adding and commenting this "unset LDFLAGS" line: https://github.com/php/php-src/commit/c4d84aa33390 https://github.com/php/php-src/commit/21a6e1f96229 https://github.com/php/php-src/commit/937358ebc7a6 https://github.com/php/php-src/commit/477649cd3f09 https://github.com/php/php-src/commit/16450418b188