Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:119593
Date: Wed, 22 Feb 2023 13:45:26 +0100
To: internals@lists.php.net
Message-ID: <Y/YOZhB/usBGnIQ5@swift.blarg.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Subject: LDFLAGS broken?
From: max+php@blarg.de (Max Kellermann)

Hi,

while working on https://github.com/php/php-src/pull/10663 I saw CI
failures because after that PR, the sanitizer flags were missing in
the linker call; they were only present in CFLAGS and LDFLAGS but not
in CXXFLAGS.

That is because ".cirrus.yml" sets LDFLAGS, but that value never gets
used because of the line "unset LIBS LDFLAGS" in configure.ac.

13 years ago, there was commit
https://github.com/php/php-src/commit/477649cd3f09 which attempted to
fix this, but was reverted on the same day by commit
https://github.com/php/php-src/commit/16450418b188 with just commit
message "Revert bad patch" but nothing else, no explanation what was
bad about the patch.

Yet the CI uses this variable, even though it's ignored.  That went
unnoticed for years, because the sanitizer flags are passed through
CFLAGS to the linker.

Who can explain this?  Shall we revert the revert to repair this?

(I despise bad commit messages like that.  A revert always needs a
proper explanation.)

Max