Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:119591
MIME-Version: 1.0
References: <CABAhh3Ed1uwS8bY75Rz_4FkhU4Bq7Fx0TexnLgQQcvhygcTgvQ@mail.gmail.com>
In-Reply-To: <CABAhh3Ed1uwS8bY75Rz_4FkhU4Bq7Fx0TexnLgQQcvhygcTgvQ@mail.gmail.com>
Date: Tue, 21 Feb 2023 13:59:30 -0400
Message-ID: <CA+hqhpeAZS-_JOuJMoOa0DgNuwv_5s_ES9u6TC=8w2yA+hcPVQ@mail.gmail.com>
Cc: php internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] Class Re-implementation Mechanism
From: weirdan@gmail.com (Bruce Weirdan)

On Tue, Feb 21, 2023 at 7:53 AM someniatko <someniatko@gmail.com> wrote:

> We want to write some tests for the Service class, but we don't want
> to use a real SomeDependency instance
> during tests. A common approach is to either extract an interface
> (JUST to make it testable), or to drop the
> `final` keyword and allow extending the class.
>
> Both approaches have their flaws:
>  - extracting an interface unnecessarily complicates the system, where
> only one "real" implementation of an interface is assumed.
>  - dropping the `final` keyword allows for the rabbit-hole of
> inheritance abuse, like greatly described in this article:
> https://front-line-php.com/object-oriented

There's another approach that requires neither: removing `final`
during class loading, for tests only.

See https://github.com/dg/bypass-finals (and
https://github.com/nunomaduro/mock-final-classes for plug'n'play
integration with PHPUnit).