Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:119558 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 65717 invoked from network); 15 Feb 2023 15:18:35 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 15 Feb 2023 15:18:35 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 75C1E18037F for ; Wed, 15 Feb 2023 07:18:34 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS24940 138.201.0.0/16 X-Spam-Virus: No X-Envelope-From: Received: from swift.blarg.de (swift.blarg.de [138.201.185.127]) by php-smtp4.php.net (Postfix) with ESMTP for ; Wed, 15 Feb 2023 07:18:33 -0800 (PST) Received: from swift.blarg.de (swift.blarg.de [IPv6:2a01:4f8:c17:52a8::2]) (Authenticated sender: max) by swift.blarg.de (Postfix) with ESMTPSA id 5714E40EDF for ; Wed, 15 Feb 2023 16:18:32 +0100 (CET) Date: Wed, 15 Feb 2023 16:18:31 +0100 To: internals@lists.php.net Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: include cleanup RFC declined From: max+php@blarg.de (Max Kellermann) On 2023/02/01 13:13, Max Kellermann wrote: > Voting starts now, please vote on my RFC: > https://wiki.php.net/rfc/include_cleanup Hi, voting of https://wiki.php.net/rfc/include_cleanup has ended today at 15 UTC. The majority of voters (52%) voted "Yes" on the primary vote - "Should #include directives be cleaned up?" - but the required supermajority for a primary vote was not met. Therefore, the primary vote is declined. On the secondary vote "Is it allowed to document an #include line with a code comment?", 90% of all voters do not want to allow code comments on #include lines. To fix the PHP code base according to this decision, please consider merging https://github.com/php/php-src/pull/10472 The secondary vote "Is it allowed to forward-declare structs/unions/typedefs?" was clearly rejected as well; 87.5% of all voters thought forward declarations should not be allowed. There are numerous unnecessary forward declarations; several of these are removed by https://github.com/php/php-src/pull/10494 - please consider merging this PR for compliance with this decision. Interestingly, of all things, the most intrusive vote ("Is it allowed to split a large header to reduce dependencies?") got accepted by a supermajority. I'll assemble a PR with just the header splitting commits and submit it for merging. From my minimal #include cleanup PR (https://github.com/php/php-src/pull/10410), I have removed all include comments. The RFC failed to meet the supermajority, but I'm not sure if that means that #include cleanups are now (or still?) forbidden. Having a majority, but no supermajority sounds like it's inconclusive, but I don't know what that means and how to proceed. Max