Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:119537 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 26887 invoked from network); 13 Feb 2023 09:28:19 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 13 Feb 2023 09:28:19 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 775EC18037E for ; Mon, 13 Feb 2023 01:28:13 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS15169 209.85.128.0/17 X-Spam-Virus: No X-Envelope-From: Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Mon, 13 Feb 2023 01:28:12 -0800 (PST) Received: by mail-ej1-f46.google.com with SMTP id hx15so30169950ejc.11 for ; Mon, 13 Feb 2023 01:28:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=l+A6s/qsZBGjeEotIhQSMrHiKa/wR+xLh1r98XEliA4=; b=Vs6xdZ41cao99uwhQ1xv42VqbvMYL/uV0unNHE2C8xA1CkfhnG5VbX5xepGahjGV7y jpo0t7kHh/p5oAjwRB6iKzmtyxx338Cjrtb8K/XjXodwMhstiAJXJ5b2itOXT/3xBRFE T9QzFhQHKf2oyQZDOCIew57KBCTe7R3VRL+62/G8dCdNj340FvDu1ps7/dZU1W0qwqvp v3WzH/qsf8/1vx1eLvT8zpCRJR79WzZHQh0tMNKLYD7Q2u6VWXqbyKcBzqbPWreux7tv 2NP2LWigrTNY71wP5ZIbLaILdQDSUnUcHBg7ONp2Nb8jtvzB41KQwcDkd7Q96UyFVabv eR4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=l+A6s/qsZBGjeEotIhQSMrHiKa/wR+xLh1r98XEliA4=; b=yCmGkXazOqGEhHoJqiFTP1o9HVwlCB2deI1qahIq/OFfq1nZTP6zMTv3MZSY3aZucc 952rnOmQYLjNljmsD+9DGEREEQ8jdOCQjZpk9BKi84mD7AODORzy3Oi5M1aTWsS8E7Hv M4EWvNiNybiE8C5of1ROgG/KAnhwn0o5cE/4QlRLqHf+xa0EGC9TetNoTcgixH9n5xB7 gsZPrM9HsyC3dRVU3p1mjSywURBk9l4zW6QT7JGN/GIXDqGhnTyFGlPCQ01dAx0HrjhT vW0jriLPTM28m/BEK2+65GKX3Ak6GrzjNvTMyD3VyPlf1O4DGSHIxocDfiwiB+cBxvc1 9PGw== X-Gm-Message-State: AO0yUKWA8BKLknjLkknOXNGlf5jGZ0hc+8z+JbeQrOYRHX5DqW6ckFSr GHxqQ2NUKIGkMm1UfvJHG6etBHG9cyZDANo68Ow= X-Google-Smtp-Source: AK7set/NTjnpqiC8+8BBBmD1y9vKgEm3ZsdgwvxG6dfWwrco4U1xEZ5mpjbvVtz+vx1DpVG87iVOpdiDNhTo1LBru9I= X-Received: by 2002:a17:906:7154:b0:888:dc91:ece6 with SMTP id z20-20020a170906715400b00888dc91ece6mr4219736ejj.6.1676280491636; Mon, 13 Feb 2023 01:28:11 -0800 (PST) MIME-Version: 1.0 References: <1cb213ea-ff7d-c4b2-5345-fadbc5953c94@bastelstu.be> In-Reply-To: Date: Mon, 13 Feb 2023 12:28:00 +0300 Message-ID: To: Max Kellermann Cc: "G. P. B." , "Matthew Weier O'Phinney" , internals@lists.php.net Content-Type: multipart/alternative; boundary="0000000000003f78fe05f4917758" Subject: Re: [PHP-DEV] [VOTE] include cleanup From: dmitrystogov@gmail.com (Dmitry Stogov) --0000000000003f78fe05f4917758 Content-Type: text/plain; charset="UTF-8" On Mon, Feb 13, 2023 at 11:35 AM Max Kellermann wrote: > On 2023/02/13 01:58, "G. P. B." wrote: > > We have had completely broken builds for longer days due to some other > > random changes, and we didn't revert them but fixed them as a follow-up. > > We still, for over 6 months now, have a "broken" ASAN build due to phpdbg > > messing up the analyser and crashing the test runner on 8.2 and master, > > something that multiple core devs, me included, need to work around by > > monkey patching the run-test.php file. > > I had a feeling there are double standards at play. The way my work > was dealt with is unprecedented! > > In the git history, I could not find any other set of PRs that was > reverted completely just for a minor one-line issue. > > > Stuff breaks all the time, and every breakage is, of course, a mistake > that should have been handled with more care, and something to learn > from. Sometimes, a revert is the right solution, but in my case, the > (demand of a) revert was unreasonable and hasty. > > > > As a final note, if the complaint had been made by anyone else other than > > Dmitry, I doubt these changes would have been reverted, and can we please > > stop pretending otherwise. > > I forget one include, break an exotic build in master branch, Dmitry > demands complete revert of 4 PRs / 61 commits (60 of which are > unrelated to the breakage). > > Dmitry breaks the whole build for everybody (including the CI) and > introduces a crash bug, merged through all three branches > (https://github.com/php/php-src/commit/a21195650e53), no revert. > > (Don't misunderstand, everybody makes mistakes, I just point out the > obvious double standard.) > > Then everybody is raving about my include comments and forward > declarations, yet the PHP code base has many of these. Turns out > those who complained the loudest have authored some of these in the > past. > > Max > Max, It's OK when commits are reverted. You are working in a common repository, and if your commits become stoppers for others they have to be reverted. Some of my commits were reverted as well. Having too many dependent commits and inability to revert a single one became an additional trouble and drew more attention to things you are doing... I didn't care about a single header change, but I do care about 100 dependent commits. After all, this includes cleanup is really questionable, and the current vote result shows that is not my sole opinion. Personally, I think this work might be very welcome during PHP-7.0 development together with other re-factoring(s). Massive permutation changes in a minor release are not acceptable for me. Maybe it makes sense to target them to PHP-9.0 Thanks. Dmitry. --0000000000003f78fe05f4917758--