Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:119521
MIME-Version: 1.0
References: <Y9pXdfDdYqnzwnIt@swift.blarg.de>
In-Reply-To: <Y9pXdfDdYqnzwnIt@swift.blarg.de>
Date: Sat, 11 Feb 2023 17:14:50 +0100
Message-ID: <CAAfnsFU71TeGJJea+u0HJ0sHSLkUYUk6=zqLj01s0oF07BaBcQ@mail.gmail.com>
To: Max Kellermann <max+php@blarg.de>
Cc: internals@lists.php.net
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] [VOTE] include cleanup
From: petk@php.net (Peter Kokot)

On Wed, 1 Feb 2023 at 13:14, Max Kellermann <max+php@blarg.de> wrote:
>
> On 2023/01/30 11:26, Max Kellermann <max+php@blarg.de> wrote:
> > If nobody objects, I'll announce the start of voting on February 1st.
>
> That's today.
>
> Voting starts now, please vote on my RFC:
>  https://wiki.php.net/rfc/include_cleanup
>
> Original discussion: https://news-web.php.net/php.internals/119272
>
> [Reposting this to create a new thread; thanks Tim for the hint.]
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: https://www.php.net/unsub.php


Hello,

I've voted in favor of the RFC because of the code-cleaning,
tech-debt-reducing improvements to code readability.

Additionally, PHP-SRC should adopt some suitable Clang-format rules
and gradually integrate them into the code.

BTW, merging from PHP 8.1 up is not problematic. Git diff only looks
at a few lines of code above and below. Not the top of the file.