Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:119514 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 50797 invoked from network); 9 Feb 2023 16:58:05 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 9 Feb 2023 16:58:05 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 9CEE7180210 for ; Thu, 9 Feb 2023 08:58:04 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS15169 209.85.128.0/17 X-Spam-Virus: No X-Envelope-From: Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Thu, 9 Feb 2023 08:58:04 -0800 (PST) Received: by mail-wm1-f45.google.com with SMTP id z13so1906189wmp.2 for ; Thu, 09 Feb 2023 08:58:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=5SbTTNM+5929FhR9tMq9k0TRSFK29k4ftMtjM3uC3mw=; b=GFEDqBc9RO33/FlqkyyB7kxV9Ogu+cjfeXLoISWwy/QZZBpwnt2Abno0zae6pCUP+D WG6CLgPCcxu7r8Tn6/YQnqiHaEdeduyZWw9PFF2RvBnM4fLOhrTW827KIkeezEvIiXuv sTRza1DDtaYW4gNahq8JIXGPQCyrZd2fvBeDf254BLFJN88RcjknyXT0KBz5OeRUVaic +defQLbZDTN89EjBZkIPipIS5nRBfwj1nQA+nIsGdztGWN3xcq9dDVjCDflWa0IFhXm7 PWtN2E5k5oxfaMOKfyJivwr/ulPdT112nYKW0JZzzB35lBGHmCLHq9KO86wklfERaiMk BU9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5SbTTNM+5929FhR9tMq9k0TRSFK29k4ftMtjM3uC3mw=; b=VDH516USCIj+DxHGRai2zu4qzJhVrmQq+OY9bvn20ZDedzPoshBFTt+YCf86eWrK4C vLyYD5cPPtJ6MVrn70gqYPQ6KeF0oHkNPFFjJguksLc5N2xZNjINrhJWeTY+kUtStRxX 1+oJEQTwwkrto1LeyI6iLFbUuZA+dFDiYNdcW7+KvTtnA+qYsd3UiXtZO0ae90uZ2Jpp seUZemNZIcSwFYydQ9Shg1CHsV1Y/hHxavYnYj4r5WDG1bt+Qh+8nAPAegoyVkfVN85+ 1Ch6fqxyYTdbSjY8jizy9xCFayX28o+Gv1lodwehpLB0J/r/D9w/KjIS/rLAO2fyXk6o hFbg== X-Gm-Message-State: AO0yUKVWAQO6DtUXXplwC/I2kqlEGTPSVrJj0l+JAUCXcgydMc7LK1JX e1VkGfudmHPtCKvIY8OgLUSs/0aDTm1n9cB5jA1/KI95 X-Google-Smtp-Source: AK7set9+dxhOU2XHFl8m/hZxPQimG07G5+JbnfxqfwwWJMcpoOJLVUoAY97i3dMy/YYjJ3C6RAQSzkYaHCaN8tYRmlk= X-Received: by 2002:a7b:cdef:0:b0:3de:e8c5:d83b with SMTP id p15-20020a7bcdef000000b003dee8c5d83bmr413564wmj.122.1675961883156; Thu, 09 Feb 2023 08:58:03 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: Date: Thu, 9 Feb 2023 16:57:51 +0000 Message-ID: To: internals@lists.php.net Content-Type: multipart/alternative; boundary="000000000000b3e50805f44748d2" Subject: Re: [PHP-DEV] How to deal with bugs in vendored libraries? From: rowan.collins@gmail.com (Rowan Tommins) --000000000000b3e50805f44748d2 Content-Type: text/plain; charset="UTF-8" On Thu, 9 Feb 2023 at 16:05, Max Kellermann wrote: > > OK, that seems clear. As far as I can see, this is the first time on this > > thread or either of the PR threads that you've actually explained that > > violation. > > I explained it already: > > https://github.com/derickr/timelib/pull/141#issuecomment-1386800720 > Right, I missed that amongst the other comments. Which, again, is why I was prompting you to clearly summarise the rationale for the change in one place, to clear up any misunderstandings. Regards, -- Rowan Tommins [IMSoP] --000000000000b3e50805f44748d2--