Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:119512
Message-ID: <184c2812-fb4e-865c-e830-450b228e989c@bastelstu.be>
Date: Thu, 9 Feb 2023 17:47:35 +0100
MIME-Version: 1.0
Content-Language: en-US
To: Sergii Shymko <sergey@shymko.net>, Rowan Tommins
 <rowan.collins@gmail.com>, "internals@lists.php.net"
 <internals@lists.php.net>
References: <PH8PR10MB63372F72B718DF413DBA13C0BFD89@PH8PR10MB6337.namprd10.prod.outlook.com>
 <CALKiJKpTYt5-BjEnv0W=JXVzR+PTvv-AKhE6Qx=6Gq-L8dsJyQ@mail.gmail.com>
 <PH8PR10MB633777DE6218F94F3B08BC6ABFD99@PH8PR10MB6337.namprd10.prod.outlook.com>
In-Reply-To: <PH8PR10MB633777DE6218F94F3B08BC6ABFD99@PH8PR10MB6337.namprd10.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] RFC proposal: values getter in BackedEnum
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=c3=bcsterhus?=)

Hi

On 2/9/23 17:18, Sergii Shymko wrote:
> BackedEnum::values() is much more convenient than array_column(BackedEnum::cases(), 'value');

I suspect the answer is "preference", but I have to ask: Why?

Personally looking at that I find it more convenient to use an existing 
function that I can apply to any array or object than having to learn 
about a new convenience method that is a few characters shorter, but 
entirely specific to enums.

It also raises the question why your proposal only includes 
BackedEnum::values() instead of also including UnitEnum::names()?

I find that I seldomly have the need for backed enums in the first 
place. The name is sufficient to uniquely identify the case and it's 
also the value that is used when serialize()ing an enum.

Best regards
Tim Düsterhus

PS: I appreciate that you follow the "no top post" rule, however I find 
it hard to identify the end of the quoted text and the beginning of your 
reply, because there is no clear separator or indicator. It also appears 
to break the externals.io parser [1], which is unfortunate. Is it 
possible for you to configure your email client to use a quote format 
that includes the standard '> ' prefix in quoted lines?

[1] https://externals.io/message/119499#119511