Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:119510
MIME-Version: 1.0
References: <Y+TIlliuIwRyZX8L@swift.blarg.de> <CALKiJKrxkUP_9H+xiw+_=1qh+=4eJhSNNowFToAJDJ7x+FQN2Q@mail.gmail.com>
 <Y+TxnQXFbIzaa+za@swift.blarg.de> <CALKiJKqHCP7=Z8nTWhb5rxQXBSzPX5DPXWNWpoVtovX4Q59M0A@mail.gmail.com>
 <Y+UZyknw0nMZPjkT@swift.blarg.de>
In-Reply-To: <Y+UZyknw0nMZPjkT@swift.blarg.de>
Date: Thu, 9 Feb 2023 16:18:06 +0000
Message-ID: <CAGBsUrfGSHqra+6rb+=uaT-Uh5D5wyT1vEuV8YrT7xOnv6Y+bg@mail.gmail.com>
To: Max Kellermann <max+php@blarg.de>
Cc: internals@lists.php.net
Content-Type: multipart/alternative; boundary="00000000000081c12b05f446badd"
Subject: Re: [PHP-DEV] How to deal with bugs in vendored libraries?
From: tekiela246@gmail.com (Kamil Tekiela)

--00000000000081c12b05f446badd
Content-Type: text/plain; charset="UTF-8"

Hi Max,

On Thu, 9 Feb 2023 at 16:05, Max Kellermann <max+php@blarg.de> wrote:

> - Jan 19 7:49 PM: commit
>   https://github.com/php/php-src/commit/0df92d218e88a0 pushed to
>   php-src
>
> Look how the commit is exactly a revert of the timelib PR that Derick
> Rethans closed and locked just the day before.
>


Ahh so it seems to be a big misunderstanding. Derrick didn't undo your
commit. Derrick simply synched timelib. The file in the commit belongs to
timelib not PHP.

Derrick is the author and the maintainer of that library. As the author, he
decides on what is merged into timelib. You submitted a PR that was
declined. No big deal. But the file should not be modified in PHP because
PHP has a readonly copy of that library. It will be overwritten whenever
Derrick syncs it up.

I'm not sure what impact this has on PHP, but as long as it compiles fine
and there are no bugs, I see no reason to pressure the maintainer of
timelib library to change their code. If it meant that the current release
of timelib suddenly becomes inoperable with PHP then we would have an
issue.

Regards,
Kamil

--00000000000081c12b05f446badd--