Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:119436
MIME-Version: 1.0
References: <CAH5C8xWsBsuzJ-7xwisUZxY+kxSmh-PhkAkPWh68c=qDs=nLrw@mail.gmail.com>
 <CALfTnfUTku4KrS7kVyHp0zuzUwhk7hMgav66OTsNVM3pwdwFog@mail.gmail.com>
In-Reply-To: <CALfTnfUTku4KrS7kVyHp0zuzUwhk7hMgav66OTsNVM3pwdwFog@mail.gmail.com>
Date: Tue, 31 Jan 2023 22:45:55 -0500
Message-ID: <CAKWdMuiS13jRiTnO17dRvnLgFsX5J+ov1XEGeX6RgMsH_=_Mvw@mail.gmail.com>
To: =?UTF-8?Q?Ond=C5=99ej_Mirtes?= <ondrej@mirtes.cz>
Cc: =?UTF-8?B?TcOhdMOpIEtvY3Npcw==?= <kocsismate90@gmail.com>, 
	PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000bc381c05f39b49ff"
Subject: Re: [PHP-DEV] [RFC] [Discussion] Typed class constants
From: mbniebergall@gmail.com (Mark Niebergall)

--000000000000bc381c05f39b49ff
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

I initiated a conversation about the typed constants RFC back in March
2022: https://externals.io/message/117406

I had updated the RFC page, but it looks like the changes were reverted in
December 2022. The updated version I was working on was:
https://wiki.php.net/rfc/typed_class_constants?rev=3D1648644637

The updated RFC looks good, thanks for working on it. You may want to
review the revised version I had worked on for implementation ideas, and
review the previous conversations.

The primary concept missing is declared but unassigned class constants,
which must then be assigned a value in the concrete class. See the section
on my revised version "Inheritance and variance". That'll be a question of
if that can or should be included in this RFC or not. It provides the most
value, allowing for inheritance from a parent class to ensure the value is
set and typed in the concrete class.

- Mark Niebergall


On Tue, Jan 31, 2023 at 5:55 PM Ond=C5=99ej Mirtes <ondrej@mirtes.cz> wrote=
:

> I fully support this RFC. PHPStan added support for PHPDoc types in class
> constants some time ago - it=E2=80=99s useful to rely on the same constan=
t type
> even in subclasses when accessing them via static:: or $object::.
>
> On Tue 31. 1. 2023 at 22:01, M=C3=A1t=C3=A9 Kocsis <kocsismate90@gmail.co=
m> wrote:
>
> > Hi Everyone,
> >
> > A few years ago, Benas Seliuginas announced the "Typed constants" RFC (
> > https://externals.io/message/110755) which apparently had a
> > positive reception overall.
> > Unfortunately, there were some issues with the implementation (namely,
> with
> > the parser)
> > so the RFC was stuck.
> >
> > A few weeks ago, I reached out to Benas whether he intended to resurrec=
t
> > the proposal, but
> > due to time constraints, he couldn't, and was OK with me continuing it.
> > With some help from
> > Bob Weinand, I managed to overcome the implementation difficulties, and
> > adapted it
> > to the newly added type-related features.
> >
> > Please find the updated RFC here:
> > https://wiki.php.net/rfc/typed_class_constants.
> >
> > Regards,
> > M=C3=A1t=C3=A9
> >
> --
>
> Ond=C5=99ej Mirtes
>

--000000000000bc381c05f39b49ff--