Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:119431 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 96031 invoked from network); 30 Jan 2023 10:26:12 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 30 Jan 2023 10:26:12 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 396D5180507 for ; Mon, 30 Jan 2023 02:26:09 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS24940 138.201.0.0/16 X-Spam-Virus: No X-Envelope-From: Received: from swift.blarg.de (swift.blarg.de [138.201.185.127]) by php-smtp4.php.net (Postfix) with ESMTP for ; Mon, 30 Jan 2023 02:26:08 -0800 (PST) Received: from swift.blarg.de (swift.blarg.de [IPv6:2a01:4f8:c17:52a8::2]) (Authenticated sender: max) by swift.blarg.de (Postfix) with ESMTPSA id D7B1F41350 for ; Mon, 30 Jan 2023 11:26:06 +0100 (CET) Date: Mon, 30 Jan 2023 11:26:05 +0100 To: internals@lists.php.net Message-ID: References: <192ba7b6-dcf0-e2da-c99e-cbad40519e27@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [PHP-DEV] RFC: rules for #include directives From: max+php@blarg.de (Max Kellermann) On 2023/01/18 15:55, Max Kellermann wrote: > Here's my RFC: https://wiki.php.net/rfc/include_cleanup Two weeks will be up the day after tomorrow, and there hasn't been any further discussion for more than a week, so I figure there is no further demand for discussing my RFC. I have replied to all emails here trying to explain my point, and today, I have updated the RFC to include the criticism expressed here. I have also prepared the vote doodles (four yes/no votes). Please tell me if you believe something is missing. If nobody objects, I'll announce the start of voting on February 1st. Three new relevant PRs I posted recently: - https://github.com/php/php-src/pull/10410 is a minimal PR for some include cleanup which also attempts to keep compatibility with "bad" extensions, e.g. by including errno.h from php.h - https://github.com/php/php-src/pull/10404 adds a few third-party extensions to the CI to detect accidental API breakages - https://github.com/php/php-src/pull/10472 removes existing #include comments which my work imitates, after three people expressed their unhappiness with the idea of comments on #include directives Max