Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:119420
MIME-Version: 1.0
References: <CAH5C8xWg6bP86qBgK9NSxL+L8dQsijeYX_YwnyiCbddoL=FefA@mail.gmail.com>
 <CAJp_myXBrmghtCAHiMOH9R9+CAg5bMnu4qP-w=2GyUUXuXsyiQ@mail.gmail.com> <CAPzBOBP0Wh+xWvCZu8JigbS2KTc3-OCB7k3cJ8t8UUXvGqBF3w@mail.gmail.com>
In-Reply-To: <CAPzBOBP0Wh+xWvCZu8JigbS2KTc3-OCB7k3cJ8t8UUXvGqBF3w@mail.gmail.com>
Date: Tue, 24 Jan 2023 11:32:09 -0600
Message-ID: <CAJp_myUuoo4qnHJfQY8_xwQTzdMZFnbG7aA1eUaMQLh88FSu3Q@mail.gmail.com>
To: Robert Landers <landers.robert@gmail.com>
Cc: =?UTF-8?B?TcOhdMOpIEtvY3Npcw==?= <kocsismate90@gmail.com>, 
	PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000d9ac1305f305e543"
Subject: Re: [PHP-DEV] [RFC] [Vote] Readonly amendments
From: mweierophinney@gmail.com ("Matthew Weier O'Phinney")

--000000000000d9ac1305f305e543
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Jan 24, 2023 at 9:13 AM Robert Landers <landers.robert@gmail.com>
wrote:

> On Tue, Jan 24, 2023 at 3:27 PM Matthew Weier O'Phinney
> <mweierophinney@gmail.com> wrote:
> >
> > On Tue, Jan 24, 2023 at 2:55 AM M=C3=A1t=C3=A9 Kocsis <kocsismate90@gma=
il.com>
> wrote:
> >
> > > Hi Everyone,
> > >
> > > We've just opened the vote for the "Readonly amendments" RFC, which i=
s
> > > going to be open for 2 weeks (until 2023-02-07).
> > >
> > > Link: https://wiki.php.net/rfc/readonly_amendments
> > > Discussion: https://externals.io/message/119007
> > >
> >
> > I missed something when reviewing previously.
> >
> > Under the Proposal 1 section is the following verbiage:
> >
> > > readonly classes can declare neither static, nor untyped properties, =
no
> > matter if the declaration is done directly in the class or indirectly
> via a
> > trait (https://github.com/php/php-src/issues/9285). Under this RFC,
> their
> > non-readonly child classes would support them as any other child class
> does.
> >
> > However, the example demonstrates neither static nor untyped properties=
.
> As
> > such, it's hard to understand what pattern you are trying to enable her=
e.
> > Could you provide an example of a child class that uses static and/or
> > untyped properties, please? Basically trying to understand what this
> would
> > enable, and why.
>
> Mocking
>

This isn't a terribly compelling argument. Readonly classes are typically
value objects; it's rare that you will mock them as they will be used as
messages or results, and you'll end up doing assertions against them =E2=80=
=94 not
mocking them.

Anything else it would enable?

--=20
Matthew Weier O'Phinney
mweierophinney@gmail.com
https://mwop.net/
he/him

--000000000000d9ac1305f305e543--