Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:119388
MIME-Version: 1.0
References: <CAH5C8xUd4ueJ62pR6vT2haz9rFgrgspJQui1rPCqTneupD+tsQ@mail.gmail.com>
 <CADyq6sLFZpM1A+V-aa3dWjY1mL=65e-kxeiyBHABNPZR2GfpKQ@mail.gmail.com>
 <CAFPFaMKc-PQD8YD6yDWPrMONcJdYqFCXgyJZuZZBVsT7VSy89A@mail.gmail.com>
 <CADyq6sJxNQKvDNsT48tsG=AUS8snbGvuR332Yaip-krd+yynaQ@mail.gmail.com>
 <CAFPFaML4Xq7Oo+pN7cAj3aQt3y3et33EzsQhxhqNZA22nOUuNw@mail.gmail.com>
 <CADK1yXLSVH0X=dteA=GO+=UPSzSDfCecALytjRFG-u+0QRyGWg@mail.gmail.com>
 <a719c9d1-de30-41d2-b7ae-24dc53a57d90@app.fastmail.com> <CAH5C8xUer=mrRNYrdYpiYk6Z+nfaeZuacCJdAa3Oi8hyw97+Cg@mail.gmail.com>
 <2115758d-79e9-340e-ed7b-176dd0927c79@bastelstu.be> <CAH5C8xWi=a+9VsSBFC4iPGvnHEBEG8Gm84+Co9+Kb491GrAukA@mail.gmail.com>
 <7a9970d7-ae3a-a989-b22c-8d39d23e1c3b@bastelstu.be>
In-Reply-To: <7a9970d7-ae3a-a989-b22c-8d39d23e1c3b@bastelstu.be>
Date: Fri, 20 Jan 2023 23:27:12 +0100
Message-ID: <CAH5C8xUZVO8oip3s-8LRa1DbXDWkaybLqe2=Tfvt=1_-RCKmLQ@mail.gmail.com>
To: =?UTF-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>
Cc: php internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000b3b69a05f2b98d5c"
Subject: Re: [PHP-DEV] [RFC] [Discussion] Readonly class amendments
From: kocsismate90@gmail.com (=?UTF-8?B?TcOhdMOpIEtvY3Npcw==?=)

--000000000000b3b69a05f2b98d5c
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hey Tim,

Thank you. It would probably make sense to create a separate copy of the
> current version of the branch, possibly creating separate PR and then to
> drop the unrelated commits from #9497 - or alternatively picking the
> first 4 commits and creating a new clean PR from that. The latter is
> probably preferable. There's a large number of comments in the PR itself
> that do not relate to the feature-as-proposed-in-the-RFC.
>

OK, I've just splitted the implementation of the two functionalities, and
submitted
https://github.com/php/php-src/pull/10389, containing only the related
changes.

I'm seeing that Nicolas already spelled out the unset() part in
> __clone(), but I think it would also be useful to have that within the
> example code. It's more easily missed in text. Examples are cheap :-)
>

I've also changed the example to include the unset case as well. :)

Best regards
M=C3=A1t=C3=A9

--000000000000b3b69a05f2b98d5c--