Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:119384
Message-ID: <511bd95b-5160-0d3a-735a-2d69a82efac3@demon-angel.eu>
Date: Fri, 20 Jan 2023 20:03:44 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Content-Language: nl
To: internals@lists.php.net
References: <CAFPFaMLtOAkRzTsqfdhvkZZ17JpUBg_WSQBpgVU6+xg-mLt2zA@mail.gmail.com>
 <5FC8DBAF-8D78-4E94-A3B0-3BDED3A3E53C@craigfrancis.co.uk>
 <789af205-4582-66a9-694a-10e18b8b9f56@demon-angel.eu>
 <CAFPFaMLAnCqhPFZHQXnABbw=aXXj53DwtaDOf=+zQ4jN1Z+OmA@mail.gmail.com>
 <9d225219-4e31-b362-52a9-9a298a0a55ef@telia.com>
 <CAFPFaM+X=H_qsVC2Nr-Qte52D0BQYxoJTxHCeh0qZNaH-ofoZg@mail.gmail.com>
 <768de46c-9ff2-eee2-24ab-e78e27ad167c@demon-angel.eu>
 <CAFPFaMJ362LKMcGK1=zkiUeA7pdsY=XYgtg49EfuQ32yP9LVUQ@mail.gmail.com>
 <828f1ec6-e8ff-01b2-dc0e-a6cf1dd16eb2@demon-angel.eu>
 <CAGBsUrcFFUYauLHmGojMU=mzXxrjT4vNNqeu_+a6AeWD3VXFsQ@mail.gmail.com>
In-Reply-To: <CAGBsUrcFFUYauLHmGojMU=mzXxrjT4vNNqeu_+a6AeWD3VXFsQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [RFC] Path to Saner Increment/Decrement operators
From: mark@demon-angel.eu (Mark Baker)


On 20/01/2023 19:48, Kamil Tekiela wrote:
> I don't think it's such a huge issue as you make it to be. The
> documentation states this only as an alternative:
> https://phpspreadsheet.readthedocs.io/en/latest/topics/accessing-cells/#looping-through-cells-using-indexes
>
> It also mentions the pitfalls. I doubt many users would prefer that
> "alternative" given that the recommended way is simpler and does the same
> thing.
> I also don't think that performance would come into play here. Any
> difference would be insignificant.
> I believe that the benefits of the deprecation outweigh any potential extra
> work the developers may have.

I beg to differ. Having done a lot of work last year recommending the 
deprecation of using of column indexes (1,2,3,etc) in favour of 
addresses ('A', 'B', 'C', etc) to more closely match with Excel's 
layout; and knowing how much the codebase uses alpha column incrementing 
internally, I'm aware of how much an issue it is.

I'd prefer if developers using PhpSpreadsheet used the built-in 
iterators, and Im in the middle of writing a post on the benefits of 
doing just that; but "under the hood" alpha column names are used, not 
numeric indexes'; so a lot of the "under the hood" code uses ++ and -- 
with row numbers and column addresses.


And replacing any PHP operator with a function call is always going to 
be less performant.


The benefits of this deprecation seem to be making ++ and -- consistent 
by making them little more than a syntactic sugar for numeric values 
only; I'm afraid I don't see that as a benefit; but as a retrograde 
step, and not the same as making ++ and -- consistent.


-- 
Mark Baker