Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:119381
Return-Path: <tim@bastelstu.be>
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 17786 invoked from network); 20 Jan 2023 17:48:51 -0000
Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5)
  by pb1.pair.com with SMTP; 20 Jan 2023 17:48:51 -0000
Received: from php-smtp4.php.net (localhost [127.0.0.1])
	by php-smtp4.php.net (Postfix) with ESMTP id 18432180212
	for <internals@lists.php.net>; Fri, 20 Jan 2023 09:48:50 -0800 (PST)
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net
X-Spam-Level: 
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,
	T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.2
X-Spam-ASN: AS24940 176.9.0.0/16
X-Spam-Virus: No
X-Envelope-From: <tim@bastelstu.be>
Received: from chrono.xqk7.com (chrono.xqk7.com [176.9.45.72])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by php-smtp4.php.net (Postfix) with ESMTPS
	for <internals@lists.php.net>; Fri, 20 Jan 2023 09:48:49 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bastelstu.be;
	s=mail20171119; t=1674236927;
	bh=moIb4pHwqayHj9ALSUGWVCtpeLlBX+PzlhImT2u8Wf0=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=WTwxY8eYbxR7WckzyNGu1GmY/2XYXisYMS/rIIuDEpv/p/pfODQBhqjoWTvsRCaZ3
	 c6bOz4fKmpC0kj0H/zeAdUqxZUQPCzP5bJxXmVqXA6/WZOl87A66meTGgJXad48nX/
	 lQOxJSrzDzZKIku6V/YK9fakZe714/5Kln0nBq+MvpZ1MJltehaS6oJuLO6qzH9w3u
	 XdLC8xIf4sDoYwAoi+jm10plGVS2z42qKRd6ZYQuZKKQE6wBnrehnQMJaZA0rZX7pG
	 dTnIRc7ySOQtkFkVYu+UY+jAMrrnfpndCFWw0CR0pRuw4NlXBU+17MEWp+iZhoMFOM
	 YBKPKz+uV+qGw==
Message-ID: <7a9970d7-ae3a-a989-b22c-8d39d23e1c3b@bastelstu.be>
Date: Fri, 20 Jan 2023 18:48:46 +0100
MIME-Version: 1.0
Content-Language: en-US
To: =?UTF-8?B?TcOhdMOpIEtvY3Npcw==?= <kocsismate90@gmail.com>
Cc: php internals <internals@lists.php.net>
References: <CAH5C8xUd4ueJ62pR6vT2haz9rFgrgspJQui1rPCqTneupD+tsQ@mail.gmail.com>
 <CADyq6sLFZpM1A+V-aa3dWjY1mL=65e-kxeiyBHABNPZR2GfpKQ@mail.gmail.com>
 <CAFPFaMKc-PQD8YD6yDWPrMONcJdYqFCXgyJZuZZBVsT7VSy89A@mail.gmail.com>
 <CADyq6sJxNQKvDNsT48tsG=AUS8snbGvuR332Yaip-krd+yynaQ@mail.gmail.com>
 <CAFPFaML4Xq7Oo+pN7cAj3aQt3y3et33EzsQhxhqNZA22nOUuNw@mail.gmail.com>
 <CADK1yXLSVH0X=dteA=GO+=UPSzSDfCecALytjRFG-u+0QRyGWg@mail.gmail.com>
 <a719c9d1-de30-41d2-b7ae-24dc53a57d90@app.fastmail.com>
 <CAH5C8xUer=mrRNYrdYpiYk6Z+nfaeZuacCJdAa3Oi8hyw97+Cg@mail.gmail.com>
 <2115758d-79e9-340e-ed7b-176dd0927c79@bastelstu.be>
 <CAH5C8xWi=a+9VsSBFC4iPGvnHEBEG8Gm84+Co9+Kb491GrAukA@mail.gmail.com>
In-Reply-To: <CAH5C8xWi=a+9VsSBFC4iPGvnHEBEG8Gm84+Co9+Kb491GrAukA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] [RFC] [Discussion] Readonly class amendments
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=c3=bcsterhus?=)

Hi

On 1/20/23 17:54, Máté Kocsis wrote:
> Sorry for the confusion! The PR contains an implementation for the "clone
> with" indeed
> just because it builds on top of some specifics of the 2nd proposal in the
> "Readonly amendments" RFC. However,
> the first few (4) commits are related to allowing modification of readonly
> properties in __clone().
> 

Thank you. It would probably make sense to create a separate copy of the 
current version of the branch, possibly creating separate PR and then to 
drop the unrelated commits from #9497 - or alternatively picking the 
first 4 commits and creating a new clean PR from that. The latter is 
probably preferable. There's a large number of comments in the PR itself 
that do not relate to the feature-as-proposed-in-the-RFC.

I'm seeing that Nicolas already spelled out the unset() part in 
__clone(), but I think it would also be useful to have that within the 
example code. It's more easily missed in text. Examples are cheap :-)

Best regards
Tim Düsterhus